Skip to content

[dashboard] Unify animated spinner for both light and dark themes #5792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

jankeromnes
Copy link
Contributor

Description

Small drive-by fix saved from #5731:

Thanks for the new spinner @gtsiolis! Happy that it works equally well on light and dark, thus we can remove the extra theme-switching logic 😌

LIGHT DARK
Screenshot 2021-09-17 at 16 07 38 Screenshot 2021-09-17 at 16 07 58
Screenshot 2021-09-17 at 16 08 31 Screenshot 2021-09-17 at 16 09 05

Related Issue(s)

The new spinner comes from #5374 (comment)

How to test

  1. Perform any action that shows a spinner (e.g. detect project configuration, run a prebuild...)

Release Notes

NONE

/uncc

Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm! 🎩

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4a722d5937362fcfe55f009efaf6baf09bc73bb4

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gtsiolis

Associated issue: #5374

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit e8f0254 into main Sep 21, 2021
@roboquat roboquat deleted the jx/refactor-spinner branch September 21, 2021 15:44
@gtsiolis gtsiolis added component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. labels Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. release-note-none size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants