[metrics] Sanitize route label with only the path #5859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/werft run 👍 started the job as gitpod-build-laushinka-http-metrics-5825.3 |
|
/werft run 👍 started the job as gitpod-build-laushinka-http-metrics-5825.5 |
laushinka
force-pushed
the
laushinka/http-metrics-5825
branch
from
10bf282 to
d84b50f
Compare
|
/werft run 👍 started the job as gitpod-build-laushinka-http-metrics-5825.7 |
|
LGTM label has been added. Git tree hash: 3e300f791257786e862917166e459a3d4eb09e0d
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: geropl Associated issue: #5825 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5825
Description
Our Prometheus route label was high in cardinality (e.g. /apps/bitbucket/callback?xxxxxx) and therefore needs to be sanitized for better observability.
Related Issue(s)
Fixes #5828
How to test
Will try @ArthurSens's cool monitoringSatellite.
Go to here and go through the
routelabel. You can also hit some endpoints in the preview env to trigger more metrics.Release Notes
/werft run with-observability withObservabilityBranch=laushinka-http-metrics-5825