-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 5 second interval automatic page reload to default 404 page for unserved ports. #5938
Conversation
default 404 page for unserved ports.
fixes: #5932 |
/werft run 👍 started the job as gitpod-build-main-fork.13 |
Codecov Report
@@ Coverage Diff @@
## main #5938 +/- ##
===========================================
+ Coverage 19.04% 68.89% +49.84%
===========================================
Files 2 8 +6
Lines 168 1315 +1147
===========================================
+ Hits 32 906 +874
- Misses 134 349 +215
- Partials 2 60 +58
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
works as expected. Thank you for the fix. /lgtm |
LGTM label has been added. Git tree hash: 963177b5997e9de4aa2bc64884d0932e6cb737a2
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csweichel Associated issue requirement bypassed by: csweichel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Add 5 second interval automatic page reload to default 404 page for unserved ports.
Why
Thought this was an easy addition of a beneficial feature, also saw it mentioned here: https://community.gitpod.io/t/auto-reload-of-port-not-available/5187
How to test
Try opening an unserved port from a running workspace and the page should automatically reload every 5 seconds until the port is served.
Release Notes