Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard] fix delete workspace GUI issues #6038

Merged
merged 1 commit into from
Oct 25, 2021
Merged

[dashboard] fix delete workspace GUI issues #6038

merged 1 commit into from
Oct 25, 2021

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Oct 5, 2021 •
edited by gtsiolis
Loading

Description

[dashboard] fix delete workspace GUI issues

Related Issue(s)

Fixes #5997

How to test

Release Notes

Truncate workspace context in the workspace deletion modal

@roboquat roboquat requested a review from svenefftinge October 5, 2021 08:02
@stale
Copy link

stale bot commented Oct 15, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Oct 15, 2021
@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Oct 15, 2021
@roboquat roboquat added the team: webapp Issue belongs to the WebApp team label Oct 15, 2021
@iQQBot
Copy link
Contributor Author

iQQBot commented Oct 15, 2021

Can anybody review this PR?

@roboquat roboquat added the lgtm label Oct 25, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: eccd9e902531f6fab1364a0bb62c052073bd512b

@gtsiolis
Copy link
Contributor

gtsiolis commented Oct 25, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-pd-delete-workspace-gui-fork.0

gtsiolis
gtsiolis approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@gtsiolis gtsiolis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing this @iQQBot! 🧡

Tried this and worked as expected. Also, added a release note since this is fixing a user facing issue. 🌮

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gtsiolis, svenefftinge

Associated issue: #5997

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit e0f6e79 into gitpod-io:main Oct 25, 2021
@iQQBot iQQBot deleted the pd/delete-workspace-gui branch October 28, 2021 05:45
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenefftinge svenefftinge svenefftinge approved these changes

@gtsiolis gtsiolis gtsiolis approved these changes

Assignees

@gtsiolis gtsiolis

@svenefftinge svenefftinge

Labels
approved community-contribution component: dashboard deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete workspace gui issues
4 participants
@iQQBot @roboquat @gtsiolis @svenefftinge