-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[server] Also re-trigger Prebuilds if the Project config has changed #6107
Conversation
5f0e711
to
ef4dc29
Compare
ef4dc29
to
aea9efc
Compare
/werft run 👍 started the job as gitpod-build-jx-retrigger-prebuild-config-changed.3 |
// If the prebuild is failed, we want to retrigger it. | ||
if (existingPB.state !== 'aborted' && existingPB.state !== 'timeout' && !existingPB.error) { | ||
// If the existing prebuild is failed, we want to retrigger it. | ||
if (!!existingPB && existingPB.state !== 'aborted' && existingPB.state !== 'timeout' && !existingPB.error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just fyi, and not related to the problem solved here, it appears to happen that a prebuilt workspace might get registered in the db but no snapshot url is set, which is basically a not available prebuild. it's clearly tricky compute that state 🙈
/lgtm it works as advertised! thanks @jankeromnes |
LGTM label has been added. Git tree hash: 109ffc305d652670d5e0238b2586a9b1b2860de2
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlexTugarev Associated issue: #6014 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Related Issue(s)
Fixes #6014
How to test
.gitpod.yml
in the repoecho "First"
to theinit
taskinit
task toecho "Second"
in the editorRelease Notes
/uncc