Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[projects] Add 'New Workspace' context menu option to all Projects cards #6185

Merged
merged 2 commits into from
Oct 13, 2021
Merged

[projects] Add 'New Workspace' context menu option to all Projects cards #6185

merged 2 commits into from
Oct 13, 2021

Conversation

jankeromnes
Copy link
Contributor

Spliced out of #6048

Description

From #6048 (comment):

A New Workspace context menu option for all Projects cards.

Screenshot 2021-10-06 at 11 28 19

Related Issue(s)

None

How to test

Release Notes

Add 'New Workspace' context menu option to all Projects cards

Documentation

@jankeromnes jankeromnes requested a review from gtsiolis October 13, 2021 08:17
@roboquat roboquat added release-note team: webapp Issue belongs to the WebApp team size/S labels Oct 13, 2021
@jankeromnes jankeromnes mentioned this pull request Oct 13, 2021
Merged
@gtsiolis
Copy link
Contributor

gtsiolis commented Oct 13, 2021 •
edited by werft-gitpod-dev-com bot
Loading

Looking at this now! 👀

gtsiolis
gtsiolis approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splicing this out of #6048, @jankeromnes!

Works like a charm! 🔮

Do you think we could cherry pick into this PR the button hover issue as it's closely related here, see #6048 (comment)? We could also add this in a follow up PR. Your call! 🏀

Approving to unblock merging but holding in case resolving the hover issue could also make it into this PR.

/hold

@roboquat roboquat added the lgtm label Oct 13, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0ecda3563a3960ee201448809869f02fa976b5db

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: gtsiolis

No associated issue. Requirement bypassed by manually added approval.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jankeromnes @gtsiolis
[dashboard] Add hover state to default 'more actions' button
a8cac16 
Co-authored-by: George Tsiolis <tsiolis.g@gmail.com>
@roboquat roboquat removed the lgtm label Oct 13, 2021
@roboquat
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Oct 13, 2021 •
edited by werft-gitpod-dev-com bot
Loading

New looks with hover state:

Screenshot 2021-10-13 at 14 14 14 Screenshot 2021-10-13 at 14 14 21 Screenshot 2021-10-13 at 14 14 31

Carrying over lgtm, as the only added change was one you wrote, and I approve it 😁 ✅ 🚀

@roboquat roboquat merged commit c670be5 into main Oct 13, 2021
@roboquat roboquat deleted the jx/projects-new-workspace branch October 13, 2021 12:19
@gtsiolis gtsiolis added component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. labels Oct 13, 2021
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Oct 31, 2021
@gtsiolis gtsiolis mentioned this pull request Dec 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtsiolis gtsiolis gtsiolis approved these changes

Assignees

@gtsiolis gtsiolis

Labels
approved component: dashboard deployed: webapp Meta team change is running in production deployed Change is completely running in production feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. release-note size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jankeromnes @gtsiolis @roboquat