-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Installer]: additional bugfixes #6448
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6448 +/- ##
==========================================
- Coverage 21.47% 7.15% -14.33%
==========================================
Files 20 10 -10
Lines 1644 923 -721
==========================================
- Hits 353 66 -287
+ Misses 1247 855 -392
+ Partials 44 2 -42
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
f830248
to
63dc1b1
Compare
25f21ac
to
14cbf07
Compare
The converts the TimeOfDay type into a string
…nsible defaults This allows us to use this with images stored in Docker Hub, eg the workspace-full
14cbf07
to
f2387ec
Compare
/lgtm |
LGTM label has been added. Git tree hash: 3baa91d2befba2deef68d60504edaf180dbef6ce
|
/approve no-issue |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csweichel Associated issue requirement bypassed by: csweichel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
More bugfixes on the installation. These are mostly due to finding errors with image building
ws-scheduler
MarshalJSON
function toTimeOfDay
to reverse theUnmarshalJSON
IdeImage
not sent to ws-managerThis is still not a complete deployment to GKE InCluster, but exists so as to share the workload
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation