-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dashboard] show error message on new project for Bitbucket-only users #6652
Conversation
51eeef4
to
c124902
Compare
/werft run 👍 started the job as gitpod-build-jk-bitbucket-message.2 |
Re-deploying as Bitbucket is now enabled on preview environments, see relevant discussion (internal). /werft run 👍 started the job as gitpod-build-jk-bitbucket-message.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave this an early look! 👀
@JanKoehnlein What do you think of using the same flow, existing components, and an alert for providing this feedback to the user instead of leading users to this error page?
BEFORE | CURRENT | PROPOSAL |
---|---|---|
Cc @jldec since you've added the error page proposal #6345. 📝
Cc @laushinka @geropl @jankeromnes @AlexTugarev in case you have any feebdack on this. 🔮
@gtsiolis absolutely. This PR is still draft mode because I did a very quick first shot at that and when I tried to look at it the preview env was broken. I can look at that between the meetings today. |
c124902
to
876b13a
Compare
1146a16
to
3000e1a
Compare
3000e1a
to
9d54786
Compare
I think an entry is missing in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: geropl Associated issue: #6345 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: e5f6cc0e787f664e106f1e6258c87bd5f04f047f
|
Whoops, should be a comment 😬 But IMO fine anyway. Can create a small follow-up PR if needed @AlexTugarev |
Description
Show a message that Bitbucket is not yet supported instead of silently failing for Bitbucket-only users on New Project page.
Related Issue(s)
Fixes #6345
How to test
Release Notes
Documentation