Skip to content

[installer] Update IDE config #6742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2021
Merged

[installer] Update IDE config #6742

merged 1 commit into from
Nov 19, 2021

Conversation

corneliusludmann
Copy link
Contributor

Description

This PR updates the IDE config in the installer. The related issues for a list of PRs of changes in the helm chart templates that are addressed in this PR.

/werft no-preview

Related Issue(s)

Fixes #6700

How to test

@mrsimonemms Could you have a look at this and tell me if I did this right? I also don't know how to test the installer.

Release Notes

NONE

@roboquat roboquat added release-note-none team: workspace Issue belongs to the Workspace team labels Nov 17, 2021
@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #6742 (49bca59) into main (16a23fd) will decrease coverage by 34.61%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #6742       +/-   ##
==========================================
- Coverage   40.78%   6.16%   -34.62%     
==========================================
  Files          23      12       -11     
  Lines        3021    1086     -1935     
==========================================
- Hits         1232      67     -1165     
+ Misses       1716    1018      -698     
+ Partials       73       1       -72     
Flag Coverage Δ
components-ee-ws-scheduler-app ?
components-ee-ws-scheduler-lib ?
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
installer-raw-app 6.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mponents/ee/ws-scheduler/pkg/scheduler/strategy.go
...ponents/ee/ws-scheduler/pkg/scheduler/scheduler.go
components/local-app/pkg/auth/pkce.go
components/ee/ws-scheduler/pkg/scaler/metrics.go
...ts/ee/ws-scheduler/pkg/scheduler/priority-queue.go
components/ee/ws-scheduler/pkg/scaler/driver.go
components/ee/ws-scheduler/pkg/scheduler/state.go
...omponents/ee/ws-scheduler/pkg/scaler/controller.go
components/ee/ws-scheduler/pkg/scaler/time.go
components/ee/ws-scheduler/pkg/scheduler/config.go
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16a23fd...49bca59. Read the comment docs.

@mrsimonemms
Copy link
Contributor

@corneliusludmann sure thing. Are you ok if I do it this afternoon or do you need it sooner? Happy to sync on it to share the installer knowledge

@corneliusludmann
Copy link
Contributor Author

Are you ok if I do it this afternoon or do you need it sooner?

No rush! I personally don't need it at all but would like to make sure the installer is in sync with the helm charts for the changes I introduced lately.

@csweichel
Copy link
Contributor

/lgtm
/approve no-issue

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: df6beaca2c60df947aeb31830b996682394d9ac5

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue: #6700

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit cfe4284 into main Nov 19, 2021
@roboquat roboquat deleted the clu/update-server-6700 branch November 19, 2021 10:19
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/M team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update server-ide-configmap in installer
4 participants