-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[installer] Update IDE config #6742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6742 +/- ##
==========================================
- Coverage 40.78% 6.16% -34.62%
==========================================
Files 23 12 -11
Lines 3021 1086 -1935
==========================================
- Hits 1232 67 -1165
+ Misses 1716 1018 -698
+ Partials 73 1 -72
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
582527e
to
49bca59
Compare
@corneliusludmann sure thing. Are you ok if I do it this afternoon or do you need it sooner? Happy to sync on it to share the installer knowledge |
No rush! I personally don't need it at all but would like to make sure the installer is in sync with the helm charts for the changes I introduced lately. |
/lgtm |
LGTM label has been added. Git tree hash: df6beaca2c60df947aeb31830b996682394d9ac5
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csweichel Associated issue: #6700 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This PR updates the IDE config in the installer. The related issues for a list of PRs of changes in the helm chart templates that are addressed in this PR.
/werft no-preview
Related Issue(s)
Fixes #6700
How to test
@mrsimonemms Could you have a look at this and tell me if I did this right? I also don't know how to test the installer.
Release Notes