-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[installer]: fix jaeger operator misconfiguration #6760
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6760 +/- ##
==========================================
- Coverage 19.04% 6.16% -12.88%
==========================================
Files 2 12 +10
Lines 168 1086 +918
==========================================
+ Hits 32 67 +35
- Misses 134 1018 +884
+ Partials 2 1 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mrsimonemms just one question, lemme know whatcha think?
f748e4b
to
10e0f9b
Compare
/approve |
/approve no-issue |
/lgtm |
LGTM label has been added. Git tree hash: d73006177635f65b7d38af9fa7087eafc0033656
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kylos101, MrSimonEmms Associated issue: #6759 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Fixed copy/pasta errors in the Jaeger operator
Related Issue(s)
Fixes #6759
How to test
Update the config:
Deploy Jaeger, changing the
nodeAffinity
key togitpod.io/workload_meta
Create a port forwarder to the jaeger deployment
kubectl port-forward jaeger-5945545574-g5jgc 3000:16686
.Go to localhost:3000 and check that there are traces flowing in
Release Notes
Documentation