-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[installer]: change default containerd runtime dir #6920
Conversation
Use Azure/AWS/GCP rather than K3s default
Codecov Report
@@ Coverage Diff @@
## main #6920 +/- ##
==========================================
- Coverage 19.04% 5.83% -13.22%
==========================================
Files 2 13 +11
Lines 168 1148 +980
==========================================
+ Hits 32 67 +35
- Misses 134 1080 +946
+ Partials 2 1 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM label has been added. Git tree hash: d8fae05c784f0abc32565e4f9ed351fc7d707076
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
it would help if we had links to pages in PR description where it says /var/lib/containerd/ is the default path for Azure/Aws etc
This is included as part of #6767 |
I think the main motivation for this change is not only AWS/Azure/GCP, but that the default root dir of containerd is /approve no-issue |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csweichel, iQQBot, princerachit Associated issue requirement bypassed by: csweichel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Use Azure/AWS/GCP rather than K3s default
How to test
Release Notes
Documentation