-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[installer]: validate that cluster meets minimum kubernetes version #6926
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6926 +/- ##
==========================================
- Coverage 33.68% 5.84% -27.85%
==========================================
Files 104 13 -91
Lines 18997 1147 -17850
==========================================
- Hits 6400 67 -6333
+ Misses 12074 1079 -10995
+ Partials 523 1 -522
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
cc9b389
to
9e8c60f
Compare
9e8c60f
to
8c757a9
Compare
@csweichel I've applied the check on the Kubernetes version as requested. I've also kept a check on a per-node basis. As I see it, we have the following options:
I must confess, I don't know the difference between 1 and 2 but it feels like 3 might cause problems - it's possible to have the control pane on one version, but the individual nodes on a different (lower) version. I'm open to suggestions |
I reckon we could merge this change as is and see how the version check fairs in the wild. /hold |
LGTM label has been added. Git tree hash: ee85a296cf4c5bc8a7b613c3aaac80eac23cb642
|
8c757a9
to
16af0f2
Compare
/lgtm |
LGTM label has been added. Git tree hash: 27550a8e92a99f63a15667210bffa117391a94ee
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csweichel Associated issue: #6828 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
Description
Validate that the min Kubernetes version should be
1.21.0-0
- using pre-release to allows for providers adding their ownpatch
to the versionRelated Issue(s)
Fixes #6828
How to test
Release Notes
Documentation