Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] When creating a new Project in your personal account, don't ask under which team to create it #6966

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented Nov 29, 2021

Description

Current situation:

  1. When visiting /new directly, we ask under which team (or personal account) to create the Project
  2. When going to a specific team and clicking on the New Project button, we don't ask
  3. When going to your personal account and clicking on the New Project button, we ask where to put the new Project

Both 1. and 2. are fine, but for 3., we already know the user intended to create a new Project for their personal account, so we don't really need to ask.

In fact, we've purposefully decided to still ask here, in order to encourage users to create new teams, but maybe this isn't actually a good idea (e.g. we've seen users get confused at this point about what a team was, and creating one "by accident").

This PR fixes it: When clicking on New Project in your personal account, the project is now created in your personal account by default (and we don't ask for team selection).

Related Issue(s)

Minimum viable change for #6686

How to test

  1. Go to your personal account
  2. Click on New Project
  3. Select a repository
  4. You should not see the team selection screen -- instead the flow should go straight to the Configuration screen

Notes:

  • When creating a new project from a specific team, Gitpod remembers which team to use thanks to a query parameter (/new?team=<ID>)
  • This PR implements something similar for when you create a new project from your personal account (i.e. /new?user=<any value>)
  • Visiting /new without context still asks under which team (or personal account) you want to create the Project

Release Notes

[dashboard] When creating a new Project in your personal account, don't ask under which team to create it

Documentation

/uncc

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Nov 30, 2021

Works as intended. 😊 Could you please take a look when you have some time @laushinka?

@laushinka
Copy link
Contributor

laushinka commented Nov 30, 2021

Works perfectly 🤗

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 940268e4937e94731433090d95e08444c21cd462

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: laushinka

Associated issue: #6686

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 32adc2c into main Nov 30, 2021
@roboquat roboquat deleted the jx/personal-project-skip-team-select branch November 30, 2021 14:03
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants