-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[installer]: add image pull secrets and custom image registry #6983
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6983 +/- ##
========================================
- Coverage 7.52% 5.76% -1.77%
========================================
Files 15 13 -2
Lines 1315 1162 -153
========================================
- Hits 99 67 -32
+ Misses 1213 1094 -119
+ Partials 3 1 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
b79f9e9
to
0532649
Compare
004cf95
to
e52fc72
Compare
e52fc72
to
036f7bc
Compare
did not test this, but code lgtm /lgtm |
LGTM label has been added. Git tree hash: 57172b589fe24af9fdb3620b47085322b4cc3b9a
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csweichel, geropl Associated issue: #6756 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Add image pull secrets to Gitpod components
Limitations
The limitations are related to the registry-facade only having a single
.dockerconfigjson
set to/mnt/pull-secret.json
as the configmap only allows a singleAuthCfg
. This means that images such asdocker-up
andsupervisor
won't be downloaded if using a different repository. If we decide to support the above two limitations, theAuthCfg
will need to accept an array of pull secrets.Mirroring
For external image names, the convention of
path/name
is followed which will make it easier to mirror. This means that anything in docker.io is written out in full - eg,alpine
becomeslibrary/alpine
. Any Gitpod images just have the given container registry replaced fully - eg,eu.gcr.io/gitpod-core-dev/build/agent-smith
becomesmynewrepo.com/agent-smith
A simple bash script to mirror images to your own registry is contained in #6756
Related Issue(s)
Fixes #6979
Fixes #6989
Fixes #6990
How to test
I have a private container registry with the images in. Can share/demo when necessary
Release Notes
Documentation