[server] When adding a project to a team, install the prebuild webhook as the adding user, not as a (random) team owner

[jankeromnes]

Description

When adding a project to a team, install the prebuild webhook as the adding user, not as a (random) team owner

Related Issue(s)

Fixes #6743 (comment)

How to test

See steps in #6743 (comment)

Release Notes

[server] When adding a project to a team, install the prebuild webhook as the adding user, not as a (random) team owner

Documentation

/uncc

[codecov]

Codecov Report

Merging #6991 (c747a4f) into main (c54c85a) will increase coverage by 12.67%.
The diff coverage is n/a.

❗ Current head c747a4f differs from pull request most recent head 6287726. Consider uploading reports for the commit 6287726 to get more accurate results

@@             Coverage Diff             @@
##             main    #6991       +/-   ##
===========================================
+ Coverage   19.04%   31.72%   +12.67%     
===========================================
  Files           2       89       +87     
  Lines         168    16347    +16179     
===========================================
+ Hits           32     5186     +5154     
- Misses        134    10710    +10576     
- Partials        2      451      +449     

Flag	Coverage Δ
components-content-service-lib	14.05% <ø> (?)
components-image-builder-app	34.44% <ø> (?)
components-image-builder-mk3-app	34.94% <ø> (?)
components-local-app-app-linux-amd64	?
components-local-app-app-linux-arm64	?
components-local-app-app-windows-386	?
components-local-app-app-windows-amd64	?
components-local-app-app-windows-arm64	?
components-supervisor-app	37.19% <ø> (?)
components-ws-daemon-app	21.96% <ø> (?)
components-ws-daemon-lib	21.96% <ø> (?)
components-ws-manager-app	40.68% <ø> (?)
components-ws-proxy-app	68.26% <ø> (?)
installer-raw-app	5.84% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go
components/supervisor/pkg/config/gitpod-config.go	79.46% <0.00%> (ø)
...s/content-service/pkg/service/ideplugin-service.go	0.00% <0.00%> (ø)
components/supervisor/pkg/ports/served-ports.go	80.00% <0.00%> (ø)
components/supervisor/pkg/terminal/ring-buffer.go	45.65% <0.00%> (ø)
components/ws-daemon/pkg/resources/limiter.go	77.77% <0.00%> (ø)
components/ws-proxy/pkg/proxy/auth.go	100.00% <0.00%> (ø)
components/content-service/pkg/git/porcelain.go	91.89% <0.00%> (ø)
...image-builder-mk3/pkg/orchestrator/orchestrator.go	41.24% <0.00%> (ø)
... and 81 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c54c85a...6287726. Read the comment docs.

[JanKoehnlein]

/lgtm

[roboquat]

LGTM label has been added.

Git tree hash: 0a468369e5a4432f128f87ae0b67ee1e6014fcbe

[roboquat]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JanKoehnlein

Associated issue: #6743

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• components/server/OWNERS [JanKoehnlein]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jankeromnes]

/hold for refactors

[jankeromnes]

Also, someone please test by joining https://jx-install-webhook-as-user.staging.gitpod-dev.com/teams/join?inviteId=bfc023a4-a415-48b3-9495-484d59fe1e70 then try to add a GitLab project 😁

[gtsiolis]

Added a GitLab project with no error. ✔️

[jankeromnes]

Thanks @gtsiolis for confirming! (Very cool choice of GitLab project 😁)

Also, thanks @JanKoehnlein for the review! Will just adjust the two minor comments and then unhold.

[roboquat]

New changes are detected. LGTM label has been removed.

[jankeromnes]

Unholding, and manually carrying over LGTM since new pushed changes are small enough: https://github.com/gitpod-io/gitpod/compare/c747a4fa215e4f9ec7412f0e74301d067b63d9ae..62877264813141b5149daee30f04a37530f01616

/unhold