-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ws-manager] Retry controlPort on conflict #7079
Conversation
Codecov Report
@@ Coverage Diff @@
## main #7079 +/- ##
==========================================
+ Coverage 32.62% 40.62% +8.00%
==========================================
Files 6 13 +7
Lines 1128 3493 +2365
==========================================
+ Hits 368 1419 +1051
- Misses 724 1959 +1235
- Partials 36 115 +79
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM label has been added. Git tree hash: cec2f98d7a4d283e0e9dc89808df9fa1584267f1
|
/approve no-issue |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csweichel, iQQBot Associated issue: #7054 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This PR makes the
ControlPort
operation in ws-manager retry on-conflict. Such edit conflicts can arise becauseControlPort
is not synchronised (i.e. multiple such operations can happen at the same time), and because of Kubernetes opportunistic concurrency model.Note: this does not actually fix #7054. The status updates happen, but the ports view does not update. This PR clearly fixes a part of the problem, but not the entire issue.
Related Issue(s)
relates to #7054
How to test
gpctl workspaces subscribe
All port exposures should trigger a status update.
Release Notes