Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup image builder mk2 #7094

Closed
wants to merge 1 commit into from
Closed

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Dec 7, 2021

Description

From #7086 it remove image builder mk2, but not clean
The reason it works is that the values under werft have not been modified

Note that the ops may need to be modified before merging

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

@roboquat
Copy link
Contributor

roboquat commented Dec 7, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign aledbf after the PR has been reviewed.
You can assign the PR to them by writing /assign @aledbf in a comment when ready.

Associated issue: #7086

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat added the size/M label Dec 7, 2021
@iQQBot iQQBot force-pushed the pd/clean-up-image-builder-mk2 branch from 76e75f9 to 02e5403 Compare December 7, 2021 06:31
@iQQBot iQQBot marked this pull request as ready for review December 7, 2021 08:03
@iQQBot
Copy link
Contributor Author

iQQBot commented Dec 7, 2021

Ready for review

@csweichel
Copy link
Contributor

I actually deliberately decided not to do this kind of cleanup, because the helm-chart is on the way out. I'd fret that by trying to cut this out nicely, we might inadvertently break production because of the intricacies of the helm chart.

I was far from clear enough in stating that, but it's what I meant with:

The helm chart remains backwards compatible, the installer never deployed mk2.

@iQQBot
Copy link
Contributor Author

iQQBot commented Dec 7, 2021

This PR is actually designed to provide compatibility, because the imageBuilder configuration item has been removed from value.yaml in #7086, and the template (like image-builder-mk3-configmap.yaml) relies on this configuration

{{ $compImgbldr := .Values.components.imageBuilder -}}

cc @csweichel close this PR

@iQQBot iQQBot closed this Dec 7, 2021
@iQQBot iQQBot deleted the pd/clean-up-image-builder-mk2 branch December 14, 2021 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants