[dashboard] Fix UI experiments #7103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
geropl
force-pushed
the
gpl/ui-experiments-2
branch
from
9d0a5f0 to
56d03a2
Compare
geropl
force-pushed
the
gpl/ui-experiments-2
branch
from
56d03a2 to
8ecaa79
Compare
|
Nice! I tested it for the Login page and also changed the localStorage to /lgtm |
|
LGTM label has been added. Git tree hash: 0f391e2017d5b595d216cfc68498f9099f3f2ad5
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: laushinka Associated issue: #7081 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Looking forward to see this visualized in our analytics tools 🤗 @jakobhero |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7081 by:
JSON.parse🙈{ [e in Experiment]: boolean }instead ofExperiment[]to allow for a random distribution (instead of slowly converging to participation in all experiments with every page load)Experimentmethods more robust (and handle all failure cases)Related Issue(s)
Context: #7081
How to test
Release Notes
Documentation