Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Minor improvements 2 #7116

Merged
merged 3 commits into from
Dec 8, 2021
Merged

[server] Minor improvements 2 #7116

merged 3 commits into from
Dec 8, 2021

Conversation

geropl
Copy link
Member

@geropl geropl commented Dec 8, 2021

Description

This PR improves upon findings from investigations around #7082:

  • explicitly set --max_old_space_size to 2048 (corresponds to this PR)
  • fix potential memory leak: 1df0ebe

Related Issue(s)

Hopefully improves #7082

How to test

Release Notes

NONE

Documentation

@geropl geropl added groundwork: in review team: webapp Issue belongs to the WebApp team labels Dec 8, 2021
@geropl geropl requested a review from JanKoehnlein December 8, 2021 09:30
@roboquat roboquat added the size/M label Dec 8, 2021
@JanKoehnlein
Copy link
Contributor

/lgtm

@roboquat
Copy link
Contributor

roboquat commented Dec 8, 2021

LGTM label has been added.

Git tree hash: c7aadb33d8d8c6de529acd335210c14c182042f3

@roboquat
Copy link
Contributor

roboquat commented Dec 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JanKoehnlein

Associated issue: #7082

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit baa41ec into main Dec 8, 2021
@roboquat roboquat deleted the gpl/7082-lag-2 branch December 8, 2021 10:53
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: webapp Meta team change is running in production deployed Change is completely running in production groundwork: in review release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants