Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspacekit] Make the enclave join ring2 netns #7124

Merged
merged 2 commits into from
Dec 8, 2021

Conversation

csweichel
Copy link
Contributor

Description

Fixes the recent image-builder issues produced by #7063. That former change failed to include the ring2 enclave in which the bob proxy runs in the network namespace of ring2.

Related Issue(s)

Fixes #7114

How to test

Open a workspace which requires an image build

Release Notes

NONE

@csweichel
Copy link
Contributor Author

csweichel commented Dec 8, 2021

/werft run with-clean-slate

👍 started the job as gitpod-build-csweichel-image-builder-mk-image-7114.2

@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #7124 (a0e196e) into main (a481e8b) will decrease coverage by 19.04%.
The diff coverage is n/a.

❗ Current head a0e196e differs from pull request most recent head 1375745. Consider uploading reports for the commit 1375745 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main   #7124       +/-   ##
==========================================
- Coverage   19.04%       0   -19.05%     
==========================================
  Files           2       0        -2     
  Lines         168       0      -168     
==========================================
- Hits           32       0       -32     
+ Misses        134       0      -134     
+ Partials        2       0        -2     
Flag Coverage Δ
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a481e8b...1375745. Read the comment docs.

@iQQBot
Copy link
Contributor

iQQBot commented Dec 8, 2021

I think should be merge with #7119 together @csweichel

@csweichel csweichel force-pushed the csweichel/image-builder-mk-image-7114 branch from a0e196e to 41879d6 Compare December 8, 2021 17:24
@csweichel csweichel marked this pull request as ready for review December 8, 2021 17:25
@csweichel csweichel force-pushed the csweichel/image-builder-mk-image-7114 branch from 49ff0b3 to 1375745 Compare December 8, 2021 17:25
@aledbf
Copy link
Member

aledbf commented Dec 8, 2021

/lgtm
/approve

@roboquat
Copy link
Contributor

roboquat commented Dec 8, 2021

LGTM label has been added.

Git tree hash: ddd85e7989eac67de3d59886ff5ba40bbcf290c9

@roboquat
Copy link
Contributor

roboquat commented Dec 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

Associated issue: #7063

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit bba56e1 into main Dec 8, 2021
@roboquat roboquat deleted the csweichel/image-builder-mk-image-7114 branch December 8, 2021 17:42
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image Builder Mk3 - image building fails when through installer
4 participants