-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[workspacekit] Make the enclave join ring2 netns #7124
Conversation
/werft run with-clean-slate 👍 started the job as gitpod-build-csweichel-image-builder-mk-image-7114.2 |
Codecov Report
@@ Coverage Diff @@
## main #7124 +/- ##
==========================================
- Coverage 19.04% 0 -19.05%
==========================================
Files 2 0 -2
Lines 168 0 -168
==========================================
- Hits 32 0 -32
+ Misses 134 0 -134
+ Partials 2 0 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I think should be merge with #7119 together @csweichel |
a0e196e
to
41879d6
Compare
49ff0b3
to
1375745
Compare
/lgtm |
LGTM label has been added. Git tree hash: ddd85e7989eac67de3d59886ff5ba40bbcf290c9
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf Associated issue: #7063 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Fixes the recent image-builder issues produced by #7063. That former change failed to include the ring2 enclave in which the bob proxy runs in the network namespace of ring2.
Related Issue(s)
Fixes #7114
How to test
Open a workspace which requires an image build
Release Notes