-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Improve paragraph accessibility in limits reached modals #7187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/assign @geropl |
/werft run 👍 started the job as gitpod-build-firstcommit-fork.0 |
/unassign Assuming @gtsiolis is taking this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing, @championshuttler! 🌟
Changes look great. ✔️
I've also triggered a preview environment (deployment) where you can see a deployed version with the changes in this PR, see #7187 (comment). 🌔
@championshuttler You'll also need to sign a Contributor License Agreement (CLA) once before merging your first contribution. Looping in @meysholdt to reach out about the CLA. 🏀
Approving but holding until the CLA process is complete.
Thanks @iQQBot for adding the labels in #7187 (comment). 🏓
/hold
LGTM label has been added. Git tree hash: 3c60273a81c88b2f14693bd67052ee851adf08b0
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gtsiolis Associated issue: #7161 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/werft run 👍 started the job as gitpod-build-firstcommit-fork.1 |
Hi Shivam, I've sent you a CLA via DocuSign. Can you sign it so we can merge this PR? thank you! |
@meysholdt thanks Done |
Thx for singing the CLA! |
/unhold |
Description
Related Issue(s)
Fixes #7161
How to test
Release Notes
Documentation