Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community: route users to Discord for support #7241

Merged
merged 1 commit into from
Jan 11, 2022
Merged

community: route users to Discord for support #7241

merged 1 commit into from
Jan 11, 2022

Conversation

kylos101
Copy link
Contributor

@kylos101 kylos101 commented Dec 15, 2021 •
edited
Loading

Description

Route users to Discord for questions and support

Related Issue(s)

Fixes #7240

Related conversation

How to test

Github links mentioned in the issue (bug report, issue template, and readme) route to Discord. We won't be able to test until we merge, I believe.

Also, @gitpod-io/engineering-meta there are a couple social links [1] [2], which I updated from Discourse to Discord. I couldn't find where they're being used, and am unsure how to test. I am unsure how to test the social type link for the configmap used by server...can you help ❓ 🙏

Release Notes

Route users to Discord for support

Documentation

@codecov
Copy link

codecov bot commented Dec 15, 2021 •
edited
Loading

Codecov Report

Merging #7241 (8d9d0a9) into main (1c75ffb) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7241      +/-   ##
==========================================
- Coverage   28.43%   28.35%   -0.08%     
==========================================
  Files          59       59              
  Lines        8294     8294              
==========================================
- Hits         2358     2352       -6     
- Misses       5765     5770       +5     
- Partials      171      172       +1
Flag Coverage Δ
components-ee-agent-smith-app 40.32% <ø> (-0.55%) ⬇️
components-ee-agent-smith-lib 40.32% <ø> (ø)
components-gitpod-cli-app 9.53% <ø> (ø)
components-gitpod-protocol-go-lib ∅ <ø> (∅)
components-local-app-app-darwin-amd64 ∅ <ø> (∅)
components-local-app-app-darwin-arm64 ∅ <ø> (∅)
components-local-app-app-linux-amd64 19.04% <ø> (ø)
components-local-app-app-linux-arm64 ∅ <ø> (∅)
components-local-app-app-windows-386 ∅ <ø> (∅)
components-local-app-app-windows-amd64 ∅ <ø> (∅)
components-local-app-app-windows-arm64 ∅ <ø> (∅)
components-supervisor-app 35.66% <ø> (ø)
installer-raw-app 5.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/supervisor/pkg/config/gitpod-config.go 76.78% <0.00%> (-2.68%) ⬇️
components/ee/agent-smith/pkg/detector/proc.go 67.60% <0.00%> (-1.87%) ⬇️
components/supervisor/pkg/ports/ports.go 61.46% <0.00%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c75ffb...8d9d0a9. Read the comment docs.

ghuntley
ghuntley reviewed Dec 15, 2021
View reviewed changes
Copy link
Contributor

@ghuntley ghuntley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some 💅🏽 and ideas.

@kylos101
Copy link
Contributor Author

kylos101 commented Dec 16, 2021 •
edited by werft-gitpod-dev-com bot
Loading

Some 💅🏽 and ideas.

thank you @ghuntley ! Very cool to see the org level templates. Is there a way for org level templates to co-exist with a repo level template - where the repo can get some features from the org, and do its own overrides? I could not find an example while searching...

@kylos101 kylos101 force-pushed the kyleb/community-issue-link branch from a260511 to c213c93 Compare December 16, 2021 19:50
@stale
Copy link

stale bot commented Dec 26, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Dec 26, 2021
@JanKoehnlein JanKoehnlein added meta: never-stale This issue can never become stale and removed meta: stale This issue/PR is stale and will be closed soon labels Dec 27, 2021
@kylos101
Copy link
Contributor Author

kylos101 commented Jan 1, 2022

Hi @gtsiolis do you know how to test the settings in installer/pkg/components/server/configmap.go?

@kylos101 kylos101 mentioned this pull request Jan 1, 2022
Closed
@JanKoehnlein
Copy link
Contributor

JanKoehnlein commented Jan 3, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-kyleb-community-issue-link.4

@JanKoehnlein JanKoehnlein mentioned this pull request Jan 7, 2022
Merged
@JanKoehnlein
Copy link
Contributor

Looks like the branding stuff is not used anywhere. I don't want to block you here, so let's update it anyway in this PR and remove it in a separate one

@kylos101 kylos101 force-pushed the kyleb/community-issue-link branch 2 times, most recently from ef142d3 to 91739b5 Compare January 10, 2022 21:06
@kylos101 kylos101 marked this pull request as ready for review January 10, 2022 21:07
@kylos101
Copy link
Contributor Author

Looks like the branding stuff is not used anywhere. I don't want to block you here, so let's update it anyway in this PR and remove it in a separate one

Thank you @JanKoehnlein. 😄

Should be all set now, let me know if anything is needed?

@gtsiolis
Copy link
Contributor

Thanks @kylos101!

@JanKoehnlein could you take one last look and merge this if changes in chart/values.yaml and installer/pkg/components/server/configmap.go look good to merge?

@gtsiolis gtsiolis requested a review from JanKoehnlein January 11, 2022 11:52
@JanKoehnlein JanKoehnlein force-pushed the kyleb/community-issue-link branch from 91739b5 to 8d9d0a9 Compare January 11, 2022 15:02
@roboquat roboquat added size/XS and removed size/S labels Jan 11, 2022
@JanKoehnlein
Copy link
Contributor

#7502 has been merged before, so I rebased this one thus removing obsolete changes.

@JanKoehnlein
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Jan 11, 2022
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4a4f149cfc97e4b40b4729625c99ee60bc2627ba

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JanKoehnlein

Associated issue: #7240

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit ac94f4f into main Jan 11, 2022
@roboquat roboquat deleted the kyleb/community-issue-link branch January 11, 2022 15:12
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtsiolis gtsiolis gtsiolis left review comments

@ghuntley ghuntley ghuntley left review comments

@JanKoehnlein JanKoehnlein Awaiting requested review from JanKoehnlein

Assignees

@JanKoehnlein JanKoehnlein

Labels
approved deployed: webapp Meta team change is running in production deployed Change is completely running in production meta: never-stale This issue can never become stale release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Route users to Discord for support
5 participants
@kylos101 @JanKoehnlein @gtsiolis @roboquat @ghuntley