Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] show repo name when workspace creation fails #7297

Conversation

trumbitta
Copy link
Contributor

@trumbitta trumbitta commented Dec 17, 2021

Description

When the creation of a workspace fails because the repo wasn't found, also display the repository name near the error messages so that in the scenario described by #7191 it becomes easier to understand what's actually going on.

Related Issue(s)

Fixes #7191

How to test

image

Release Notes

[dashboard] Error messages on workspace creation when the repository is not found, will now also display the name of the repository

Documentation

@roboquat roboquat added release-note team: webapp Issue belongs to the WebApp team labels Dec 17, 2021
@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jldec after the PR has been reviewed.
You can assign the PR to them by writing /assign @jldec in a comment when ready.

Associated issue: #7191

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@iQQBot
Copy link
Contributor

iQQBot commented Dec 18, 2021

Hi, thanks for your contribution

@iQQBot
Copy link
Contributor

iQQBot commented Dec 18, 2021

cannot handle job for gitpod-build-trumbitta-display-name-of-the-repository-7191-fork.0: Pod "gitpod-build-trumbitta-display-name-of-the-repository-7191-fork.0" is invalid: metadata.labels: Invalid value: "gitpod-build-trumbitta-display-name-of-the-repository-7191-fork.0": must be no more than 63 characters

@trumbitta Please submit another PR, and short your branch name, thanks!

@trumbitta
Copy link
Contributor Author

trumbitta commented Dec 18, 2021

I'll do it as soon as I am able, but... Gitpod created the branch name for me 🤣🤣🤣

@trumbitta trumbitta closed this Dec 18, 2021
@trumbitta trumbitta deleted the trumbitta/display-name-of-the-repository-7191 branch December 18, 2021 21:09
@trumbitta
Copy link
Contributor Author

trumbitta commented Dec 18, 2021

@iQQBot #7302 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display name of the repository on the "Repository not found" error screen
3 participants