Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[observability] Team Workspace / Success Criteria dashboard -> no data #7354

Merged
merged 2 commits into from
Dec 23, 2021
Merged

[observability] Team Workspace / Success Criteria dashboard -> no data #7354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36de3f0
Fixes #7335
kylos101 Dec 21, 2021
925031d
Helm is needed to support Observability
kylos101 Dec 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions operations/observability/mixins/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,10 @@ There are a couple of ways to trigger a werft job that will deploy a preview env

1. You can open a Pull Request with the following line in the description:
```
/werft with-observability
# we deploy using K8s manifests generated by our new installer
# observability only works with our old helm chart
# to support observability, use with-helm will;
/werft with-observability with-helm

# Just in case your PR requires extra configuration on Prometheus side
# (and you have a new branch on https://github.com/gitpod-io/observability with such changes)
Expand All @@ -309,13 +312,13 @@ There are a couple of ways to trigger a werft job that will deploy a preview env

2. After opening a Pull Request, you can add a Github comment:
```
/werft run with-observability
/werft run withObservabilityBranch="<my-branch>"
/werft run with-observability with-helm
/werft run withObservabilityBranch="<my-branch>" with-observability
```

3. Inside your workspace, run:
```
werft run github -a with-observability="" -a withObservabilityBranch="<my-branch>"
werft run github -a with-observability=true -a withObservabilityBranch="<my-branch>" -a with-helm=true
```

As mentioned in [How is our mixin consumed?](#How-is-our-mixin-consumed), please remember that a commit must be done for us to update monitoring-satellite with the dashboards/alerts/recording rule changes.
Expand Down
56 changes: 46 additions & 10 deletions operations/observability/mixins/workspace/dashboards/success-criteria.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,17 @@
},
"editable": true,
"fiscalYearStartMonth": 0,
"gnetId": null,
"graphTooltip": 0,
"id": 56,
"id": 52,
"iteration": 1640278118309,
"links": [],
"liveNow": false,
"panels": [
{
"datasource": "$datasource",
"datasource": {
"type": "prometheus",
"uid": "${datasource}"
},
"fieldConfig": {
"defaults": {
"color": {
Expand Down Expand Up @@ -100,8 +103,13 @@
},
"targets": [
{
"exemplar": true,
"expr": "1-((\n (\n sum(rate(gitpod_ws_manager_workspace_stops_total{reason=\"failed\",type!~\"GHOST|PREBUILD\"}[1d]))\n /\n sum(rate(gitpod_ws_manager_workspace_stops_total{type!~\"GHOST|PREBUILD\"}[1d]))\n )\n) + (\n (\n sum(rate(grpc_server_handled_total{grpc_method=\"StartWorkspace\",grpc_code!~\"OK|ResourceExhausted\"}[1d]))\n /\n sum(rate(grpc_server_handled_total{grpc_method=\"StartWorkspace\"}[1d]))\n )\n))",
"datasource": {
"type": "prometheus",
"uid": "${datasource}"
},
"exemplar": false,
"expr": "1-((\n (\n sum(rate(gitpod_ws_manager_workspace_stops_total{reason=\"failed\",type!~\"GHOST|PREBUILD\"}[1d])) OR on() vector(0)\n /\n sum(rate(gitpod_ws_manager_workspace_stops_total{type!~\"GHOST|PREBUILD\"}[1d]))\n )\n) + (\n (\n sum(rate(grpc_server_handled_total{grpc_method=\"StartWorkspace\",grpc_code!~\"OK|ResourceExhausted\"}[1d])) OR on() vector(0)\n /\n sum(rate(grpc_server_handled_total{grpc_method=\"StartWorkspace\"}[1d]))\n )\n))",
"instant": false,
"interval": "",
"legendFormat": "Success Rate",
"refId": "A"
Expand All @@ -111,7 +119,10 @@
"type": "timeseries"
},
{
"datasource": "$datasource",
"datasource": {
"type": "prometheus",
"uid": "${datasource}"
},
"fieldConfig": {
"defaults": {
"color": {
Expand Down Expand Up @@ -183,8 +194,12 @@
},
"targets": [
{
"datasource": {
"type": "prometheus",
"uid": "${datasource}"
},
"exemplar": true,
"expr": "histogram_quantile(0.95, \n sum(\n rate(gitpod_ws_manager_workspace_startup_seconds_bucket{type!=\"GHOST\",type!=\"PREBUILD\"}[1d])\n ) by (le, cluster)\n)",
"expr": "histogram_quantile(\n 0.95, \n sum(\n rate(gitpod_ws_manager_workspace_startup_seconds_bucket{type!=\"GHOST\",type!=\"PREBUILD\"}[1d])\n ) by (le, cluster)\n )",
"interval": "",
"legendFormat": "{{cluster}}",
"refId": "A"
Expand All @@ -194,14 +209,34 @@
"type": "timeseries"
}
],
"schemaVersion": 31,
"refresh": "1m",
"schemaVersion": 34,
"style": "dark",
"tags": [
"workspace",
"success criteria"
],
"templating": {
"list": []
"list": [
{
"current": {
"selected": true,
"text": "prometheus",
"value": "prometheus"
},
"hide": 0,
"includeAll": false,
"multi": false,
"name": "datasource",
"options": [],
"query": "prometheus",
"queryValue": "",
"refresh": 1,
"regex": "",
"skipUrlSync": false,
"type": "datasource"
}
]
},
"time": {
"from": "now-7d",
Expand All @@ -211,5 +246,6 @@
"timezone": "",
"title": "Success Criteria",
"uid": "jgjwvIc7k",
"version": 2
"version": 3,
"weekStart": ""
}