[ws-manager] Improve workspaces PodAffinity

[aledbf]

Description

If EnforceWorkspaceNodeAffinity is configured, ensure the workspaces are scheduled in nodes where ws-daemon and registry-facade are running.

Release Notes

[ws-manager] Improve workspaces PodAffinity

How to test

• scale down ws-scheduler replicas to 0
• change ws-manager configmap and remove schedulerName
• restart ws-manager
• start a workspace
• check the workspace contains the affinity

nodeSelectorTerms:
- matchExpressions:
  - key: gitpod.io/ws-daemon_ready_ns_<namespace>
    operator: Exists
  - key: gitpod.io/registry-facade_ready_ns_<namespace>
    operator: Exists

/werft with-clean-slate-deployment

[codecov]

Codecov Report

Merging #7472 (5e6487a) into main (972dfeb) will decrease coverage by 0.80%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##            main   #7472      +/-   ##
========================================
- Coverage   8.69%   7.88%   -0.81%     
========================================
  Files         33      31       -2     
  Lines       2323    2155     -168     
========================================
- Hits         202     170      -32     
+ Misses      2117    1983     -134     
+ Partials       4       2       -2     

Flag	Coverage Δ
components-gitpod-cli-app	10.38% <ø> (ø)
components-local-app-app-darwin-amd64	?
components-local-app-app-darwin-arm64	?
components-local-app-app-linux-amd64	?
components-local-app-app-linux-arm64	?
components-local-app-app-windows-386	?
components-local-app-app-windows-amd64	?
components-local-app-app-windows-arm64	?
installer-raw-app	5.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 972dfeb...5e6487a. Read the comment docs.

[csweichel]

Code looks good. However, when I try this by

• scaling ws-scheduler to zero replicas
• removing the schedulerName entry from the ws-manager config and restarting ws-manager,
• ensuring that no registry-facade instances are running in my namespace

The pod still gets scheduled, even though there's no registry-facade present.

The workspace pod had the correct podAffinity and schedulerName set. It's doubtful this is caused by the namespace setup in core-dev either, considering we're running on 1.21 and PodAffinityNamespaceSelector was introduced in 1.22.

[aledbf]

/werft run

👍 started the job as gitpod-build-aledbf-podaffinity.9

[aledbf]

/werft run

👍 started the job as gitpod-build-aledbf-podaffinity.59

[aledbf]

/werft run

👍 started the job as gitpod-build-aledbf-podaffinity.60

[aledbf]

/werft with-clean-slate-deployment

👎 unknown command: with-clean-slate-deployment
Use /werft help to list the available commands

[aledbf]

/werft run

👍 started the job as gitpod-build-aledbf-podaffinity.62

[csweichel]

/lgtm

[roboquat]

LGTM label has been added.

Git tree hash: 26b7b7df863a120b0c9d49f8c839bf3cfb84441b

[aledbf]

/assign @mrsimonemms

[corneliusludmann]

/approve no-issue

[roboquat]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: corneliusludmann, csweichel

Associated issue requirement bypassed by: corneliusludmann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• components/registry-facade/OWNERS [csweichel]
• components/ws-daemon/OWNERS [csweichel]
• components/ws-manager/OWNERS [csweichel]
• installer/OWNERS [corneliusludmann]
• installer/pkg/components/registry-facade/OWNERS [csweichel]
• installer/pkg/components/ws-daemon/OWNERS [csweichel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment