Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Theia references from the CLI component #7507

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Remove Theia references from the CLI component #7507

merged 1 commit into from
Jan 14, 2022

Conversation

filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Jan 7, 2022 •
edited
Loading

Description

Removes some references to the now removed Theia IDE.

Related Issue(s)

See #5511 & #7395

How to test

  1. Open the preview environment
  2. Try using the gp env and gp preview

Release Notes

NONE

@filiptronicek filiptronicek changed the title Clean up some Theia references Remove Theia references from the CLI component Jan 7, 2022
@codecov
Copy link

codecov bot commented Jan 7, 2022 •
edited
Loading

Codecov Report

Merging #7507 (04e773c) into main (b6f9c58) will decrease coverage by 22.06%.
The diff coverage is 5.55%.

❗ Current head 04e773c differs from pull request most recent head 7e38dc7. Consider uploading reports for the commit 7e38dc7 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             main    #7507       +/-   ##
===========================================
- Coverage   32.45%   10.38%   -22.07%     
===========================================
  Files         155       18      -137     
  Lines       24257      992    -23265     
===========================================
- Hits         7872      103     -7769     
+ Misses      15701      888    -14813     
+ Partials      684        1      -683
Flag Coverage Δ
components-blobserve-app ?
components-blobserve-lib ?
components-common-go-lib ?
components-content-service-api-go-lib ?
components-content-service-app ?
components-content-service-lib ?
components-ee-agent-smith-app ?
components-ee-agent-smith-lib ?
components-ee-kedge-app ?
components-ee-ws-scheduler-app ?
components-ee-ws-scheduler-lib ?
components-gitpod-cli-app 10.38% <5.55%> (+0.81%) ⬆️
components-gitpod-protocol-go-lib ?
components-ide-code-desktop-status-app ?
components-image-builder-api-go-lib ?
components-image-builder-bob-app ?
components-image-builder-bob-runc-facade ?
components-image-builder-mk3-app ?
components-licensor-lib ?
components-local-app-api-go-lib ?
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-openvsx-proxy-app ?
components-openvsx-proxy-lib ?
components-registry-facade-api-go-lib ?
components-registry-facade-app ?
components-registry-facade-lib ?
components-service-waiter-app ?
components-supervisor-api-go-lib ?
components-supervisor-app ?
components-workspacekit-app ?
components-ws-daemon-api-go-lib ?
components-ws-daemon-app ?
components-ws-daemon-lib ?
components-ws-daemon-nsinsider-app ?
components-ws-manager-api-go-lib ?
components-ws-manager-app ?
components-ws-manager-bridge-api-go-lib ?
components-ws-proxy-app ?
dev-blowtorch-app ?
dev-loadgen-app ?
dev-poolkeeper-app ?
dev-sweeper-app ?
dev-version-manifest-app ?
installer-raw-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/gitpod-cli/cmd/credential-helper.go 1.34% <0.00%> (+0.09%) ⬆️
components/gitpod-cli/cmd/env.go 19.63% <0.00%> (+5.21%) ⬆️
components/gitpod-cli/cmd/preview.go 36.73% <ø> (+4.59%) ⬆️
components/gitpod-cli/cmd/git-track-command.go 8.00% <8.00%> (ø)
components/gitpod-cli/cmd/version.go 40.00% <40.00%> (ø)
components/supervisor/pkg/supervisor/config.go
components/supervisor/pkg/supervisor/services.go
components/supervisor/pkg/supervisor/ssh.go
components/supervisor/pkg/supervisor/supervisor.go
components/supervisor/pkg/supervisor/user.go
... and 135 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6f9c58...7e38dc7. Read the comment docs.

@filiptronicek filiptronicek marked this pull request as ready for review January 10, 2022 11:37
filiptronicek
filiptronicek commented Jan 10, 2022
View reviewed changes
Copy link
Member Author

@filiptronicek filiptronicek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I broke the gp env command

gitpod /workspace/template-typescript-node $ gp env
cannot get environment variables: not found

@filiptronicek filiptronicek self-assigned this Jan 10, 2022
@filiptronicek
Clean up some theia references
7e38dc7 
Fix condition

remove `printVarFromTheia`

Unused theia lib
@filiptronicek filiptronicek force-pushed the ft/remove-thaia-refs-1 branch from 04e773c to 7e38dc7 Compare January 11, 2022 13:08
@filiptronicek
Copy link
Member Author

/unhold

@akosyakov
Copy link
Member

akosyakov commented Jan 11, 2022 •
edited
Loading

make sure to smoke test all affected commands 🙏

or write unit tests for them 😉

@filiptronicek
Copy link
Member Author

@akosyakov I think it might be better to just leave the unit tests for another PR. I tested both of the affected commands and all should be well.

iQQBot
iQQBot approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@iQQBot iQQBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat added the lgtm label Jan 14, 2022
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: da0b07e152c97d99ca514d8505c8ba37c024a3a1

@iQQBot
Copy link
Contributor

iQQBot commented Jan 14, 2022

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iQQBot

Associated issue requirement bypassed by: iQQBot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 9619985 into main Jan 14, 2022
@roboquat roboquat deleted the ft/remove-thaia-refs-1 branch January 14, 2022 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iQQBot iQQBot iQQBot approved these changes

Assignees

@iQQBot iQQBot

@filiptronicek filiptronicek

Labels
approved release-note-none size/L team: IDE
Projects
🚀 IDE Team
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@filiptronicek @akosyakov @roboquat @iQQBot