Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer] Adjust rabbitmq helm chart probes configuration #7596

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jan 13, 2022

Description

Improve rabbitmq initial start time.

Related Issue(s)

Fixes #

How to test

Release Notes

[installer] Adjust rabbitmq helm chart probes configuration

@roboquat roboquat added release-note team: delivery Issue belongs to the self-hosted team size/S labels Jan 13, 2022
@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #7596 (4d3d23e) into main (1f5495f) will decrease coverage by 1.95%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##            main   #7596      +/-   ##
========================================
- Coverage   9.53%   7.57%   -1.96%     
========================================
  Files         18      31      +13     
  Lines       1080    2243    +1163     
========================================
+ Hits         103     170      +67     
- Misses       976    2071    +1095     
- Partials       1       2       +1     
Flag Coverage Δ
components-gitpod-cli-app 9.53% <ø> (ø)
installer-raw-app 5.76% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
installer/pkg/common/render.go 0.00% <0.00%> (ø)
installer/pkg/common/objects.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/role.go 0.00% <0.00%> (ø)
installer/pkg/common/ca.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/rolebinding.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/deployment.go 0.00% <0.00%> (ø)
...components/ws-manager/unpriviledged-rolebinding.go 0.00% <0.00%> (ø)
installer/pkg/common/display.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/configmap.go 29.71% <0.00%> (ø)
installer/pkg/components/ws-manager/tlssecret.go 0.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f5495f...4d3d23e. Read the comment docs.

@aledbf aledbf requested a review from mrsimonemms January 13, 2022 22:28
Copy link
Contributor

@mrsimonemms mrsimonemms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve no-issue

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1b243f9b6666b8f5eae09f091740776311d526e1

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrSimonEmms

Associated issue requirement bypassed by: MrSimonEmms

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 8434006 into main Jan 14, 2022
@roboquat roboquat deleted the aledbf/rabit branch January 14, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved release-note size/S team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants