Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[protocol] use owner and repo in lower case in ws IDs #7609

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

JanKoehnlein
Copy link
Contributor

@JanKoehnlein JanKoehnlein commented Jan 14, 2022

Follow up to #7391

I don't want to be "anoehnlein"

NONE

@geropl
Copy link
Member

geropl commented Jan 14, 2022

/werft run

👍 started the job as gitpod-build-jk-lowercase-ws-id.2

Tests did timeout.

@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #7609 (598eeb9) into main (972dfeb) will increase coverage by 1.68%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            main    #7609      +/-   ##
=========================================
+ Coverage   8.69%   10.38%   +1.68%     
=========================================
  Files         33       18      -15     
  Lines       2323      992    -1331     
=========================================
- Hits         202      103      -99     
+ Misses      2117      888    -1229     
+ Partials       4        1       -3     
Flag Coverage Δ
components-gitpod-cli-app 10.38% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
installer-raw-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...components/ws-manager/unpriviledged-rolebinding.go
...staller/pkg/components/ws-manager/networkpolicy.go
installer/pkg/common/ca.go
installer/pkg/common/objects.go
installer/pkg/common/storage.go
components/local-app/pkg/auth/pkce.go
installer/pkg/common/common.go
installer/pkg/components/ws-manager/tlssecret.go
installer/pkg/components/ws-manager/rolebinding.go
components/local-app/pkg/auth/auth.go
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 972dfeb...598eeb9. Read the comment docs.

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: d79e0de76b1e1e69bdb98a27ba637bbf9265d6fc

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geropl

Associated issue: #7391

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 5550be1 into main Jan 14, 2022
@roboquat roboquat deleted the jk/lowercase-ws-id branch January 14, 2022 15:13
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants