Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer] Telemetry should not run in workspace clusters #7687

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jan 19, 2022

Description

There is no database in workspace clusters

Related Issue(s)

Fixes #7686

How to test

Release Notes

[installer] Telemetry should not run in workspace clusters

Documentation

@roboquat roboquat added release-note team: delivery Issue belongs to the self-hosted team labels Jan 19, 2022
@aledbf aledbf requested a review from mrsimonemms January 19, 2022 12:37
@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #7687 (2934621) into main (92a9fd5) will decrease coverage by 0.80%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##            main   #7687      +/-   ##
========================================
- Coverage   8.68%   7.88%   -0.81%     
========================================
  Files         33      31       -2     
  Lines       2325    2157     -168     
========================================
- Hits         202     170      -32     
+ Misses      2119    1985     -134     
+ Partials       4       2       -2     
Flag Coverage Δ
components-gitpod-cli-app 10.38% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
installer-raw-app 5.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92a9fd5...2934621. Read the comment docs.

@mrsimonemms
Copy link
Contributor

/lgtm
/approve no-issue

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: b12746eed2fa2c1efb5d03c5abd7db0fbcbfe6da

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrSimonEmms

Associated issue: #7686

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit f29518d into main Jan 19, 2022
@roboquat roboquat deleted the aledbf/cronsh branch January 19, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved release-note size/XS team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[installer] workspace clusters do not have a database
3 participants