Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installation-telemetry]: log data sent to Segment #7730

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

mrsimonemms
Copy link
Contributor

Description

Log data sent to Segment to the console. This is to provide transparency in the data we send and to prove that we're not providing anything that could be used to identify an installation.

Related Issue(s)

Fixes #7540

How to test

Release Notes

[installation-telemetry]: log data sent to Segment

Documentation

@roboquat roboquat added release-note team: delivery Issue belongs to the self-hosted team size/XS labels Jan 20, 2022
This is to provide transparency in what we're logging and to
prove we're not storing any data that could identify an installation
@mrsimonemms mrsimonemms force-pushed the sje/telemetry-logging branch from a80afcf to ccd03ce Compare January 20, 2022 15:35
@mrsimonemms
Copy link
Contributor Author

/assign @corneliusludmann

@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #7730 (ccd03ce) into main (8c3e9a0) will decrease coverage by 1.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7730      +/-   ##
==========================================
- Coverage   11.63%   10.38%   -1.26%     
==========================================
  Files          20       18       -2     
  Lines        1160      992     -168     
==========================================
- Hits          135      103      -32     
+ Misses       1022      888     -134     
+ Partials        3        1       -2     
Flag Coverage Δ
components-gitpod-cli-app 10.38% <ø> (ø)
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c3e9a0...ccd03ce. Read the comment docs.

Copy link
Contributor

@corneliusludmann corneliusludmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@roboquat roboquat added the lgtm label Jan 21, 2022
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: a79cd3aeac31c9ab98d02403d0f7d1333888ff38

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: corneliusludmann

Associated issue: #7540

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 7eb7d13 into main Jan 21, 2022
@roboquat roboquat deleted the sje/telemetry-logging branch January 21, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved release-note size/XS team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question - should we log the data we send to console?
3 participants