-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[content-init] Propagate sensible error messages #7753
Conversation
when the content initializer fails
/werft run 👍 started the job as gitpod-build-cw-fix-7605.4 |
Codecov Report
@@ Coverage Diff @@
## main #7753 +/- ##
===========================================
+ Coverage 11.54% 28.19% +16.64%
===========================================
Files 20 44 +24
Lines 1169 5668 +4499
===========================================
+ Hits 135 1598 +1463
- Misses 1031 3953 +2922
- Partials 3 117 +114
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
LGTM label has been added. Git tree hash: 4423a23c70a4f197262784f735d321ecfbb78266
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Furisto Associated issue: #7605 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This PR provides more detailed error messages when the content initializer fails. It does that by passing a unix pipe to the content initializer process started by ws-daemon, to which that process can write error messages. We can't just use the stderr/stdout of the content initializer process because that's too verbose and JSON formatted. With this design we have more control over the final error message.
Related Issue(s)
Fixes #7605
How to test
Release Notes