Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[content-init] Propagate sensible error messages #7753

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Conversation

csweichel
Copy link
Contributor

Description

This PR provides more detailed error messages when the content initializer fails. It does that by passing a unix pipe to the content initializer process started by ws-daemon, to which that process can write error messages. We can't just use the stderr/stdout of the content initializer process because that's too verbose and JSON formatted. With this design we have more control over the final error message.

Related Issue(s)

Fixes #7605

How to test

Release Notes

Improved feedback when content initialisation fails

when the content initializer fails
@csweichel
Copy link
Contributor Author

csweichel commented Jan 21, 2022

/werft run

👍 started the job as gitpod-build-cw-fix-7605.4

@roboquat roboquat added team: workspace Issue belongs to the Workspace team size/M labels Jan 21, 2022
@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #7753 (60939d9) into main (9a7411f) will increase coverage by 16.64%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #7753       +/-   ##
===========================================
+ Coverage   11.54%   28.19%   +16.64%     
===========================================
  Files          20       44       +24     
  Lines        1169     5668     +4499     
===========================================
+ Hits          135     1598     +1463     
- Misses       1031     3953     +2922     
- Partials        3      117      +114     
Flag Coverage Δ
components-gitpod-cli-app 10.28% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-ws-manager-app 40.77% <ø> (?)
installer-raw-app 5.75% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go
installer/pkg/common/ca.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/tlssecret.go 0.00% <0.00%> (ø)
...components/ws-manager/unpriviledged-rolebinding.go 0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/annotations.go 65.11% <0.00%> (ø)
components/ws-manager/pkg/manager/monitor.go 9.46% <0.00%> (ø)
installer/pkg/components/ws-manager/role.go 0.00% <0.00%> (ø)
installer/pkg/common/render.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/deployment.go 0.00% <0.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a7411f...60939d9. Read the comment docs.

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4423a23c70a4f197262784f735d321ecfbb78266

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Furisto

Associated issue: #7605

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 990dd33 into main Jan 21, 2022
@roboquat roboquat deleted the cw/fix-7605 branch January 21, 2022 13:03
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/M team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[content-initializer] Provide actionable feedback when content init fails
3 participants