Skip to content

[team-sub] fix wording on add members #7811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2022
Merged

[team-sub] fix wording on add members #7811

merged 1 commit into from
Jan 25, 2022

Conversation

svenefftinge
Copy link
Member

@svenefftinge svenefftinge commented Jan 25, 2022

fixes #7806

NONE

@gtsiolis
Copy link
Contributor

gtsiolis commented Jan 25, 2022

Looking at this now! 👀

@gtsiolis
Copy link
Contributor

gtsiolis commented Jan 25, 2022

/werft run

👍 started the job as gitpod-build-se-team-plan-wording.1

@gtsiolis gtsiolis self-requested a review January 25, 2022 12:25
Copy link
Contributor

@jldec jldec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny grammar change - my fault sorry.

@@ -609,10 +609,10 @@ function AddMembersModal(props: {
return (<Modal visible={true} onClose={props.onClose}>
<h3 className="pb-2">Add Members</h3>
<div className="border-t border-b border-gray-200 dark:border-gray-800 mt-2 -mx-6 px-6 py-4">
<p className="pb-4 text-gray-500 text-base">Add members to the team plan.</p>
<p className="pb-4 text-gray-500 text-base">Select the number of members to add the team plan.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a to

Select the number of members to add to the team plan.

@roboquat roboquat added the lgtm label Jan 25, 2022
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: d9a8f7715ffd2f9618b3dd5fdce3623b7ad9719f

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jldec

Associated issue: #7806

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gtsiolis gtsiolis removed their request for review January 25, 2022 12:35
@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #7811 (58a2536) into main (5d721fc) will decrease coverage by 1.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7811      +/-   ##
==========================================
- Coverage   11.46%   10.20%   -1.27%     
==========================================
  Files          20       18       -2     
  Lines        1177     1009     -168     
==========================================
- Hits          135      103      -32     
+ Misses       1039      905     -134     
+ Partials        3        1       -2     
Flag Coverage Δ
components-gitpod-cli-app 10.20% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d721fc...58a2536. Read the comment docs.

@roboquat roboquat merged commit e4746d2 into main Jan 25, 2022
@roboquat roboquat deleted the se-team-plan-wording branch January 25, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Team Plans] Clarify Add Members Dialog
4 participants