-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Limit desktop editor options width on large viewports #7842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #7842 +/- ##
==========================================
- Coverage 11.46% 10.20% -1.27%
==========================================
Files 20 18 -2
Lines 1177 1009 -168
==========================================
- Hits 135 103 -32
+ Misses 1039 905 -134
+ Partials 3 1 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 54a96882cc033dfcfee4c16da2cf10e517a4e1b4
|
/approve no-issue |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JanKoehnlein Associated issue requirement bypassed by: JanKoehnlein The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Danke, @JanKoehnlein! ⚾ |
Παρακαλώ, @gtsiolis |
Description
This will limit the desktop editor options width, following the practice we've used in acount settings[1].
See relevant discussion (internal) and #7031 (comment). Cc @gitpod-io/engineering-ide
Screenshots
Some preferences options have been removed to demonstrate this better.
Release Notes