Skip to content

Limit desktop editor options width on large viewports #7842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Jan 26, 2022

Description

This will limit the desktop editor options width, following the practice we've used in acount settings[1].

See relevant discussion (internal) and #7031 (comment). Cc @gitpod-io/engineering-ide

Screenshots

Some preferences options have been removed to demonstrate this better.

BEFORE AFTER
Screenshot 2022-01-26 at 5 08 59 PM Screenshot 2022-01-26 at 5 09 36 PM

Release Notes

NONE

@roboquat roboquat added release-note-none team: webapp Issue belongs to the WebApp team size/XS labels Jan 26, 2022
@gtsiolis gtsiolis requested a review from a team January 26, 2022 15:15
@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #7842 (be7493e) into main (f9ec0f8) will decrease coverage by 1.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7842      +/-   ##
==========================================
- Coverage   11.46%   10.20%   -1.27%     
==========================================
  Files          20       18       -2     
  Lines        1177     1009     -168     
==========================================
- Hits          135      103      -32     
+ Misses       1039      905     -134     
+ Partials        3        1       -2     
Flag Coverage Δ
components-gitpod-cli-app 10.20% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9ec0f8...be7493e. Read the comment docs.

Copy link
Contributor

@JanKoehnlein JanKoehnlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 54a96882cc033dfcfee4c16da2cf10e517a4e1b4

@JanKoehnlein
Copy link
Contributor

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JanKoehnlein

Associated issue requirement bypassed by: JanKoehnlein

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 499ac3a into main Jan 27, 2022
@roboquat roboquat deleted the gt/limit-desktop-options-width branch January 27, 2022 08:03
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Jan 27, 2022

Danke, @JanKoehnlein! ⚾

@JanKoehnlein
Copy link
Contributor

JanKoehnlein commented Jan 27, 2022

Παρακαλώ, @gtsiolis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants