-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add metric to track failed manifest requests from registry-facade #7905
Conversation
Codecov Report
@@ Coverage Diff @@
## main #7905 +/- ##
==========================================
- Coverage 11.46% 10.20% -1.27%
==========================================
Files 20 18 -2
Lines 1177 1009 -168
==========================================
- Hits 135 103 -32
+ Misses 1039 905 -134
+ Partials 3 1 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/werft run with-obsevability 👍 started the job as gitpod-build-pavel-track-failed-layer-pulls.3 |
/werft run with-obsevability 👍 started the job as gitpod-build-pavel-track-failed-layer-pulls.6 |
/werft run with-obsevability with-clean-slate-deployment 👍 started the job as gitpod-build-pavel-track-failed-layer-pulls.11 |
/werft run with-helm with-clean-slate-deployment 👍 started the job as gitpod-build-pavel-track-failed-layer-pulls.12 |
/werft run with-obsevability 👍 started the job as gitpod-build-pavel-track-failed-layer-pulls.13 |
/werft run with-observability 👍 started the job as gitpod-build-pavel-track-failed-layer-pulls.14 |
b280905
to
24b17b2
Compare
/lgtm |
LGTM label has been added. Git tree hash: bb485037428c4d9500a0a9f9365fe34c1d7bc865
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csweichel Associated issue: #7886 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Add metric to track failed manifest requests.
Related Issue(s)
Fixes #7886
How to test
Run registry facade and block traffic to upstream. Observe metric counter increasing.
Release Notes
Documentation