Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metric to track failed manifest requests from registry-facade #7905

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

sagor999
Copy link
Contributor

Description

Add metric to track failed manifest requests.

Related Issue(s)

Fixes #7886

How to test

Run registry facade and block traffic to upstream. Observe metric counter increasing.

Release Notes

 Add metric for tracking failed manifest requests from registry-facade

Documentation

@sagor999 sagor999 requested a review from aledbf January 28, 2022 19:54
@roboquat roboquat added release-note team: workspace Issue belongs to the Workspace team size/S labels Jan 28, 2022
@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #7905 (b280905) into main (5ede718) will decrease coverage by 1.26%.
The diff coverage is n/a.

❗ Current head b280905 differs from pull request most recent head 24b17b2. Consider uploading reports for the commit 24b17b2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7905      +/-   ##
==========================================
- Coverage   11.46%   10.20%   -1.27%     
==========================================
  Files          20       18       -2     
  Lines        1177     1009     -168     
==========================================
- Hits          135      103      -32     
+ Misses       1039      905     -134     
+ Partials        3        1       -2     
Flag Coverage Δ
components-gitpod-cli-app 10.20% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ede718...24b17b2. Read the comment docs.

@sagor999 sagor999 marked this pull request as draft January 28, 2022 20:02
@sagor999
Copy link
Contributor Author

sagor999 commented Jan 28, 2022

/werft run with-obsevability

👍 started the job as gitpod-build-pavel-track-failed-layer-pulls.3

@sagor999
Copy link
Contributor Author

sagor999 commented Jan 28, 2022

/werft run with-obsevability

👍 started the job as gitpod-build-pavel-track-failed-layer-pulls.6

@sagor999
Copy link
Contributor Author

sagor999 commented Jan 28, 2022

/werft run with-obsevability with-clean-slate-deployment

👍 started the job as gitpod-build-pavel-track-failed-layer-pulls.11

@sagor999
Copy link
Contributor Author

sagor999 commented Jan 28, 2022

/werft run with-helm with-clean-slate-deployment

👍 started the job as gitpod-build-pavel-track-failed-layer-pulls.12

@sagor999
Copy link
Contributor Author

sagor999 commented Jan 28, 2022

/werft run with-obsevability

👍 started the job as gitpod-build-pavel-track-failed-layer-pulls.13

@sagor999
Copy link
Contributor Author

sagor999 commented Jan 28, 2022

/werft run with-observability

👍 started the job as gitpod-build-pavel-track-failed-layer-pulls.14

@sagor999 sagor999 requested a review from aledbf January 28, 2022 23:05
@roboquat roboquat added size/XXL and removed size/S labels Jan 28, 2022
@sagor999 sagor999 force-pushed the pavel/track-failed-layer-pulls branch from b280905 to 24b17b2 Compare January 28, 2022 23:16
@sagor999 sagor999 marked this pull request as ready for review January 28, 2022 23:16
@csweichel
Copy link
Contributor

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: bb485037428c4d9500a0a9f9365fe34c1d7bc865

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue: #7886

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 2fb5775 into main Jan 31, 2022
@roboquat roboquat deleted the pavel/track-failed-layer-pulls branch January 31, 2022 09:11
@roboquat roboquat added the deployed: workspace Workspace team change is running in production label Jan 31, 2022
@roboquat roboquat added the deployed Change is completely running in production label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/XXL team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add metric to track failed layer pull by registry-facade
4 participants