-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ws-manager] Refactor connectToWorkspaceDaemon helper #7926
Conversation
Codecov Report
@@ Coverage Diff @@
## main #7926 +/- ##
==========================================
+ Coverage 8.57% 33.80% +25.22%
==========================================
Files 33 31 -2
Lines 2355 4505 +2150
==========================================
+ Hits 202 1523 +1321
- Misses 2149 2867 +718
- Partials 4 115 +111
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
/lgtm |
LGTM label has been added. Git tree hash: 03e31ff4d308e67257dd5b21b956f4dda1a1fca1
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csweichel Associated issue: #7688 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Do not rely on endpoints but instead, search ws-daemon pods.
xref: #7688
How to test
cannot connect to ws-daemon
Release Notes