Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-manager] Refactor connectToWorkspaceDaemon helper #7926

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jan 31, 2022

Description

Do not rely on endpoints but instead, search ws-daemon pods.

xref: #7688

How to test

  • Workspaces should open without errors
  • ws-manager los should not contain cannot connect to ws-daemon

Release Notes

[wa-manager] Refactor connectToWorkspaceDaemon helper

@roboquat roboquat added release-note team: workspace Issue belongs to the Workspace team size/L labels Jan 31, 2022
@aledbf aledbf changed the title [wa-manager] Refactor connectToWorkspaceDaemon helper [ws-manager] Refactor connectToWorkspaceDaemon helper Jan 31, 2022
@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #7926 (3165e8e) into main (5f9f701) will increase coverage by 25.22%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##            main    #7926       +/-   ##
==========================================
+ Coverage   8.57%   33.80%   +25.22%     
==========================================
  Files         33       31        -2     
  Lines       2355     4505     +2150     
==========================================
+ Hits         202     1523     +1321     
- Misses      2149     2867      +718     
- Partials       4      115      +111     
Flag Coverage Δ
components-gitpod-cli-app 10.20% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-ws-manager-app 40.61% <93.33%> (?)
installer-raw-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-manager/pkg/manager/manager.go 23.02% <93.33%> (ø)
installer/pkg/components/ws-manager/configmap.go
installer/pkg/components/ws-manager/rolebinding.go
...components/ws-manager/unpriviledged-rolebinding.go
installer/pkg/components/ws-manager/role.go
installer/pkg/common/storage.go
installer/pkg/components/ws-manager/deployment.go
components/local-app/pkg/auth/pkce.go
installer/pkg/common/display.go
installer/pkg/common/ca.go
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f9f701...3165e8e. Read the comment docs.

@csweichel
Copy link
Contributor

/lgtm

@roboquat
Copy link
Contributor

roboquat commented Feb 1, 2022

LGTM label has been added.

Git tree hash: 03e31ff4d308e67257dd5b21b956f4dda1a1fca1

@roboquat
Copy link
Contributor

roboquat commented Feb 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue: #7688

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved release-note size/L team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on workspace start: "Cannot connect to ws-daemon"
4 participants