-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[gitlab] support nested repos in envvar patterns #7975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Associated issue: #2702 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Don't know whether we want that as we deprecate the patterns anyway. |
/werft run 👍 started the job as gitpod-build-jk-env-vars-in-nested-github-repos.1 |
Agree that the repository pattern is deprecated and should go away. However, this does seem like a risk-free short-term quality-of-life improvement, so I'd be happy to test / review / approve it, especially since the use case of "personal env var specific to a project" is not currently supported without the prefix:
We could imagine adding a new section to the Project Env Vars page to replace the broken user-level prefix:
I think this (combined with also "team-level variables") would allow us to completely retire the repo prefix, and move to this support chart:
|
Codecov Report
@@ Coverage Diff @@
## main #7975 +/- ##
=========================================
+ Coverage 8.82% 10.86% +2.03%
=========================================
Files 33 18 -15
Lines 2380 1022 -1358
=========================================
- Hits 210 111 -99
+ Misses 2165 909 -1256
+ Partials 5 2 -3
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
/werft run with-clean-slate-deployment 👍 started the job as gitpod-build-jk-env-vars-in-nested-github-repos.2 |
Closed in favor of #7978 with a shorter branch name that doesn't crash the preview env |
Description
Support nested repos in user-scoped env var patterns.
Related Issue(s)
Fixes #2702
How to test
See #2702
Release Notes
Documentation