-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Approve changelog PRs using GH reviews #7979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@JanKoehnlein when you were developing this, how did you test it? |
Codecov Report
@@ Coverage Diff @@
## main #7979 +/- ##
==========================================
- Coverage 12.01% 10.86% -1.16%
==========================================
Files 20 18 -2
Lines 1190 1022 -168
==========================================
- Hits 143 111 -32
+ Misses 1043 909 -134
+ Partials 4 2 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Note to myself based on chat with Jan
|
@mads-hartmann I am not sure how to test this anymore, since we moved it to a GH action. But you have to manually build the next version docker files
and then update the version in the GitHub action in order to use it. |
0d3edc8
to
34a74d3
Compare
@JanKoehnlein I found a (somewhat tedious) way to test program. I have left a description of how I did so in the PR in case need to test it in the future |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Cool, one bot approving another 🤖
LGTM label has been added. Git tree hash: 8c08dc8b83cbb68666156d65f0dfb90c36e0fafc
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JanKoehnlein Associated issue: #841 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
As part of moving to using GitHub for managing reviews instead of Prow we will be removing the
/approve
commands in favour of using actual GH reviews (see RFC for more details). This means that any automation that uses/approve
needs to be modified.This PR extends the changelog program to also approve the PR using GitHub. Once we have switched to GitHub Reviews entirely we can remove the comments and the
lgtm
andapproved
labels from this program, but for now the program will continue to approve using the old way while we move everything over.Related Issue(s)
Fixes https://github.com/gitpod-io/ops/issues/841
How to test
Testing this is a bit tedious, here's a PR that shows that it was able to open a PR and approve it.
.github/workflows/changelog.yml
) to use the new image-b
argument to/app/changelog update
should bemain
instead ofGITHUB_REF
), but have it open PRs against your test branch (the-b
argument to/app/changelog pr
should be your test branch, e.g.mads/old-changelog
).Release Notes
Documentation
N/A