-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add CODEOWNERS file #7998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CODEOWNERS file #7998
Conversation
Codecov Report
@@ Coverage Diff @@
## main #7998 +/- ##
==========================================
- Coverage 12.01% 10.86% -1.16%
==========================================
Files 20 18 -2
Lines 1190 1022 -168
==========================================
- Hits 143 111 -32
+ Misses 1043 909 -134
+ Partials 4 2 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
645cae8
to
c99b31b
Compare
looks great. We should ask the team leads to double check that the GitHub teams are correct. /lgtm |
LGTM label has been added. Git tree hash: e4fdebf5d0c63aea2c83e57278f0a6cdd8479479
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csweichel Associated issue: #839 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@csweichel I was too slow to add the hold label so now this is merged 😬 I won't revert as the CODEOWNERS file doesn't do much yet. Before enabling branch protection rules to require reviews from code owners I'll ping the leads to verify the CODEOWNERS file looks correct. |
/installer/pkg/components/ws-manager-bridge @gitpod-io/engineering-webapp | ||
/installer/pkg/components/ws-manager @gitpod-io/engineering-workspace | ||
/installer/pkg/components/ws-proxy @gitpod-io/engineering-workspace | ||
/installer/pkg/config/versions @gitpod-io/engineering-ide @gitpod-io/engineering-ide @gitpod-io/engineering-ide @gitpod-io/engineering-ide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think once is enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha this turned out to be a bug. Fixing in upcoming PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was fixed in https://github.com/gitpod-io/gitpod/pull/8000/files and there were not other cases of multiple teams being approvers in the same OWNERS file
# A single review is enough. Usually the review will be done by RoboQuat but we don't want to add | ||
# that user as an owner in case we need to manually approve changes | ||
# | ||
/CHANGELOG.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. That should make the changelog job a lot easier!
For posterity I reviewed the CODEOWNERS file and LGTM. |
Description
As part of moving to using Github for PR review automation we are going to remove OWNERS in favour of CODEOWNERS (see RFC for details).
This PR adds the CODEOWNERS file. We will remove the OWNERS files once we have switched Tide to use Github Reviews (instead of the approved label, see gitpod-io/gitbot#65).
This can be merged now. The CODEOWNERS will then show up as "suggested" reviewers when you open a PR but reviews from CODEOWNERS are not required (we'll enable that later).
The CODEOWNERS file was generated using the following script and then modified slightly
Updated: there was a bug in the original script, see here. The script below has been updated in case we need to run it again)
Related Issue(s)
Part of https://github.com/gitpod-io/ops/issues/839
How to test
CODEOWNERS is hard to test. Once merged we should see the CODEOWNERS show up as suggested Reviewers when opening PRs.
Release Notes
Documentation
N/A