-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[jb-remote] hook gp cli #8025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jb-remote] hook gp cli #8025
Conversation
0693dce
to
4009c14
Compare
Codecov Report
@@ Coverage Diff @@
## main #8025 +/- ##
==========================================
- Coverage 11.98% 10.82% -1.16%
==========================================
Files 20 18 -2
Lines 1193 1025 -168
==========================================
- Hits 143 111 -32
+ Misses 1046 912 -134
+ Partials 4 2 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
4009c14
to
c526268
Compare
f4eab07
to
ac09196
Compare
791caf9
to
ab1c0de
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Associated issue: #7980 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6e989fe
to
3980803
Compare
/werft run 👍 started the job as gitpod-build-ak-jb-remote-git.19 |
3980803
to
df7c530
Compare
f65a919
to
f81cf80
Compare
d9592e0
to
a8a4072
Compare
a8a4072
to
6339cb1
Compare
6339cb1
to
34d131c
Compare
@felladrin should be addressed, please double check before approving 🙏 otherwise do approve and let's deploy it tomorrow for testing with JB |
Thanks! Rechecking now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code reviewed ✅
Tested with the same steps mentioned on the PR description ✅
Start a workspace with IntelliJ: https://ak-jb-remote-git.staging.gitpod-dev.com/#referrer:jetbrains-gateway/https://github.com/gitpod-io/spring-petclinic
Try git push from cli and UI, you should see a notification about missing scopes in both cases. Clicking on the link should take you in access control page.
Trying to push via CLI:
Trying to push via UI:
Grant missing scopes in the access control page and check that you can now trigger push from cli and UI without issues.
Access control page before setting permissions:
Access control page after setting permissions:
After setting permissions, git push
works as expected:
gp open pom.xml should open pom.xml file from terminal
gp open pom.xml --wait should open pom.xml file from terminal and block it till file is not closed
gp preview $(gp url 8080) should open the browser page
Description
This PR enables support of gp CLI in JB products, namely credential helper, open and preview commands.
Caveat: It breaks gp cli in VS Code running alongside of JB products. We will have a look into separately: https://gitpod.slack.com/archives/C01KGM9BH54/p1644223793552719
This PR also include project specific IntelliIJ configs to enable dog fooding.
Related Issue(s)
Fixes #7980, fixes #7848
How to test
gp open pom.xml
should open pom.xml file from terminalgp open pom.xml --wait
should open pom.xml file from terminal and block it till file is not closedgp preview $(gp url 8080)
should open the browser pageDesign Review
You can find pair review with @felladrin here.
Release Notes
Documentation