Basic Bitbucket Server support (login and workspace start)

[corneliusludmann]

Description

The most recent version of Bitbucket Server (7.20) supports OAuth2 for authentication, we're now able to connect Gitpod with.

This PR enables login and start of plain workspaces for a repository hosted on a Bitbucket Server (version 7.20).

Known limitations and things out of scope here:

• support for / context of the default branch by default, i.e. no issue/pr context supported
• broken token validation in the IDE, i.e. it reports missing permissions, though the commits might get pushed
• no support for projects/webhooks/prebuilds so far
• no support UI to configure the integration with, i.e. server's config is to be manually adjusted to add an entry for authProviderConfigs

Related Issue(s)

Fixes #7957

How to test

Unfortunately, there is no way to set up the auth provider in the frontend. One needs to patch the server-config configmap in order to get this running in a Gitpod installation. To do so you need to edit the config map:

EDITOR="code --wait" kubectl edit configmap server-config

and add such a configuration:

"authProviderConfigs": [{
    "id": "bitbucketserver",
    "type": "BitbucketServer",
    "host": "bitbucket.gitpod-self-hosted.com",
    "hiddenOnDashboard": false,
    "disallowLogin": false,
    "oauth": {
        "clientId": "<REDACTED>",
        "clientSecret": "<REDACTED>",
        "callBackUrl": "https://clu-bitbucket-server.staging.gitpod-dev.com/auth/bitbucket.gitpod-self-hosted.com/callback",
        "authorizationUrl": "https://bitbucket.gitpod-self-hosted.com/rest/oauth2/latest/authorize",
        "tokenUrl": "https://bitbucket.gitpod-self-hosted.com/rest/oauth2/latest/token",
        "scope": "PUBLIC_REPOS REPO_READ REPO_WRITE REPO_ADMIN PROJECT_ADMIN",
        "scopeSeparator": " "
    }
}]

after that, you'd need to restart the server pods by running:

kubeclt delete pod server-[TAB]

Release Notes

Bitbucket Server: Authorize with Bitbucket Server 7.20 and start workspaces.

[codecov]

Codecov Report

Merging #8086 (8b801f7) into main (30da763) will decrease coverage by 1.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #8086      +/-   ##
==========================================
- Coverage   12.31%   11.17%   -1.14%     
==========================================
  Files          20       18       -2     
  Lines        1161      993     -168     
==========================================
- Hits          143      111      -32     
+ Misses       1014      880     -134     
+ Partials        4        2       -2     

Flag	Coverage Δ
components-gitpod-cli-app	11.17% <ø> (ø)
components-local-app-app-darwin-amd64	?
components-local-app-app-darwin-arm64	?
components-local-app-app-linux-amd64	?
components-local-app-app-linux-arm64	?
components-local-app-app-windows-386	?
components-local-app-app-windows-amd64	?
components-local-app-app-windows-arm64	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30da763...8b801f7. Read the comment docs.

[AlexTugarev]

I'm taking over from here. Thanks @corneliusludmann !

[AlexTugarev]

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-clu-bitbucket-server.9

[jldec]

I can login using my own bb server credentials 🎉

[jldec]

I cannot start a workspace - tried lots of variations of

https://clu-bitbucket-server.staging.gitpod-dev.com/#https://bitbucket.gitpod-self-hosted.com/users/jldec/repos/test-repo/browse

[jldec]

That repo does exist
https://bitbucket.gitpod-self-hosted.com/users/jldec/repos/test-repo/browse

[jldec]

Haven't looked at the code - just tested
I can login, but I can't start a workspace.

[jldec]

@AlexTugarev it would be helpful if you could describe what BB Server context URL shapes are supported now.
(I'm just spending time guessing)

It looks like you got the following to work
https://bitbucket.gitpod-self-hosted.com/projects/JLDEC/repos/test123/browse

But this one does not work
https://bitbucket.gitpod-self-hosted.com/users/jldec/repos/test-repo/browse

[jldec]

/werft run

👍 started the job as gitpod-build-clu-bitbucket-server.11

[jldec]

Hi @AlexTugarev
The build is failing tslint with

src/bitbucket-server/bitbucket-server-repository-provider.ts(13,14): error TS2420: Class 'BitbucketRepositoryProvider' incorrectly implements interface 'RepositoryProvider'.
  Property 'getUserRepos' is missing in type 'BitbucketRepositoryProvider' but required in type 'RepositoryProvider'.
error Command failed with exit code 2.

[AlexTugarev]

/werft run

👍 started the job as gitpod-build-clu-bitbucket-server.16

[jldec]

Thank you @AlexTugarev
/LGTM

I am able to

• authenticate with my BBServer credentials
• start workspaces for repositories under /users and /projects
• NOT create projects for BB Server repos (expected)
• connect integrations for GitLab or GitHub
• create projects and run workspaces on for GitLab