Update helm installer with config for new cpu limiter #8124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagor999
reviewed
Feb 9, 2022
| @@ -26,7 +26,7 @@ type Config struct { | |||
| Enabled bool `json:"enabled"` | |||
| TotalBandwidth resource.Quantity `json:"totalBandwidth"` | |||
| Limit resource.Quantity `json:"limit"` | |||
| BurstLimit resource.Quantity `json:"bustLimit"` | |||
| BurstLimit resource.Quantity `json:"burstLimit"` | |||
There was a problem hiding this comment.
@csweichel heh. I suspect due to this typo bursting might not be working quite right in current gen31 deploy. FYI.
There was a problem hiding this comment.
The installer also has bustLimit, so it should work. Planning on updating that next.
There was a problem hiding this comment.
Ah you are right! Thank you!
There was a problem hiding this comment.
the installer uses the same structure, hence would have the same (incorrect) behaviour
sagor999
approved these changes
Feb 9, 2022
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#8036 reworked the cpu limiting that ws-daemon is doing. We also need to update the helm installer with the new configuration for ws-daemon. This broke staging as ws-daemon expected the new configuration but the configmap still had the old configuration.
Related Issue(s)
n.a.
How to test
Open preview environment which has been installed with helm and check that ws-daemon is running and workspaces can be opened
Release Notes