-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Use prettier for TypeScript files in .werft #8245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d0a0a81
to
6e9bed3
Compare
6e9bed3
to
2094d05
Compare
|
Codecov Report
@@ Coverage Diff @@
## main #8245 +/- ##
===========================================
- Coverage 31.21% 11.17% -20.04%
===========================================
Files 39 18 -21
Lines 5908 993 -4915
===========================================
- Hits 1844 111 -1733
+ Misses 3924 880 -3044
+ Partials 140 2 -138
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
I have added the hold label. I'm checking with the other teams that write TS to ensure this doesn't break anything for them. |
Nice job! I'd approve right away if the build didn't fail... looks like it is some unrelated flakiness though, I'll rerun to see if it passes /werft run 👍 started the job as gitpod-build-mads-prettier-werft.5 |
What is the status of this one? Are we still waiting for IDE/WebApp review? If that's the case I guess we could add them as reviewers? 🙂 |
@ArthurSens I will try to use the default formatter that VSCode ships with instead of prettier. I can't figure out how to downgrade a PR to DRAFT so instead I'll just close this and reopen a new one once I have experimented |
@ArthurSens Thanks! Reopened and converted it to draft :D |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Closing this, the webapp team is working on adding automatic formatting so I'd rather wait and piggy-back on their implementation. See internal Slack thread for reference |
Description
This PR introduces automatic formatting of all TypeScript files in the
.werft
folder..werft
folder as part of our pre-commit hooks.esbenp.prettier-vscode
to the list of extensionsThis PR also includes performing the automatic formatting, hence the rather large diff. For the actual code review I suggest you focus on 43ca5ee.
Related Issue(s)
Fixes #8066
How to test
Verify that it performs formatting when you run
Edit a
ts
file inserver
and verify it doesn't use prettier to format the file when saving (that is, the prettier extension that is now installed as part of the workspace correctly ignores the entire components folder)Release Notes
Documentation
N/A