Skip to content

[dashboard] Ensure we fetch IDEOptions onload + onNewInstance #8250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

geropl
Copy link
Member

@geropl geropl commented Feb 16, 2022

Description

Follow up for #8125, specifically this comment.

Related Issue(s)

Context: #8125

How to test

  • start workspace in tab 1
  • open dashboard in tab 2
  • stop workspace from tab 2
  • change IDE settings and set local IDE
  • start workspace in tab 2
  • note how tab 1 shows IDEoptions now

Release Notes

NONE

Documentation

@geropl geropl requested a review from a team February 16, 2022 16:19
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Feb 16, 2022
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@JanKoehnlein JanKoehnlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit e6e1804 into main Feb 16, 2022
@roboquat roboquat deleted the gpl/call-ideoptions branch February 16, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants