Skip to content

Fix dotfiles permission #8286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Fix dotfiles permission #8286

merged 1 commit into from
Feb 18, 2022

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Feb 17, 2022

Description

In #7569 we change to use content-services API to use download dotfiles, but it is not able to set user credential, so the .dotfiles belong root

Also, it fixes some breaking changes in #7569, which is not expected (exec multiple installation scripts, the expect is exec only once: see document )

Gitpod will recognize and run one of the following install scripts from your dotfiles repository.
If there is no install script, your dotfiles will be symlinked into /home/gitpod.

Related Issue(s)

Fixes #

How to test

  1. Set a dotfiles
  2. open workspaces
  3. check the ~/.dotfiles permission, it should belong gitpod
  4. check the behavior, It should work as the document says

Release Notes

NONE

Documentation

  • /werft version=staging-pd-fix-dotfiles
  • /werft namespace=staging-pd-fix-dotfiles

@iQQBot iQQBot requested review from a team February 17, 2022 17:27
@github-actions github-actions bot added team: IDE team: workspace Issue belongs to the Workspace team labels Feb 17, 2022
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #8286 (6ebb375) into main (6497329) will increase coverage by 4.72%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8286      +/-   ##
==========================================
+ Coverage   31.23%   35.96%   +4.72%     
==========================================
  Files          39       19      -20     
  Lines        5910     4752    -1158     
==========================================
- Hits         1846     1709     -137     
+ Misses       3923     2908    -1015     
+ Partials      141      135       -6     
Flag Coverage Δ
components-gitpod-cli-app ?
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-supervisor-app 35.96% <0.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/supervisor/pkg/supervisor/supervisor.go 6.45% <0.00%> (-0.02%) ⬇️
components/gitpod-cli/cmd/git-token-validator.go
components/gitpod-cli/cmd/version.go
components/gitpod-cli/cmd/root.go
components/gitpod-cli/cmd/await-port.go
components/gitpod-cli/cmd/preview.go
components/gitpod-cli/cmd/env.go
components/gitpod-cli/cmd/snapshot.go
components/gitpod-cli/cmd/open.go
components/gitpod-cli/cmd/gitpodRun.go
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6497329...6ebb375. Read the comment docs.

Furisto
Furisto previously approved these changes Feb 17, 2022
@mustard-mh
Copy link
Contributor

mustard-mh commented Feb 17, 2022

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-pd-fix-dotfiles-error-permission.1

@mustard-mh
Copy link
Contributor

mustard-mh commented Feb 17, 2022

branch chars too much, not work to build staging 😅

@mustard-mh
Copy link
Contributor

mustard-mh commented Feb 17, 2022

/werft run version=staging-pd-fix-dotfiles namespace=staging-pd-fix-dotfiles

👍 started the job as gitpod-build-pd-fix-dotfiles-error-permission.3

@mustard-mh
Copy link
Contributor

image

owner not change

cc @iQQBot

@iQQBot iQQBot force-pushed the pd/fix-dotfiles-error-permission branch from af86adb to 34ca399 Compare February 17, 2022 18:18
@roboquat roboquat added size/XS and removed size/S labels Feb 17, 2022
@mustard-mh
Copy link
Contributor

~/.dotfile and ~/.dotfile/* belong to gitpod now

@iQQBot iQQBot force-pushed the pd/fix-dotfiles-error-permission branch from 34ca399 to 6ebb375 Compare February 17, 2022 18:35
@roboquat roboquat added size/S and removed size/XS labels Feb 17, 2022
@iQQBot
Copy link
Contributor Author

iQQBot commented Feb 17, 2022

Also, it fixes some breaking changes in #7569, which is not expected (exec multiple installation scripts, the expect is exec only once: see document )

@iQQBot
Copy link
Contributor Author

iQQBot commented Feb 17, 2022

image

image

@roboquat roboquat merged commit 26e2777 into main Feb 18, 2022
@roboquat roboquat deleted the pd/fix-dotfiles-error-permission branch February 18, 2022 08:56
@roboquat roboquat added the deployed: IDE IDE change is running in production label Feb 18, 2022
@iQQBot iQQBot removed the team: workspace Issue belongs to the Workspace team label Feb 18, 2022
@iQQBot iQQBot added the deployed Change is completely running in production label Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/S team: IDE
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants