Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer] Remove default workspace template #8288

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Conversation

corneliusludmann
Copy link
Contributor

Description

With this change, the installer does not add the default workspace template (e.g. default DNS settings) when no workspace template is given. The old implementation even overwrote the self-configured settings.

Related Issue(s)

Fixes #8221

How to test

docker create -ti --name installer eu.gcr.io/gitpod-core-dev/build/installer:clu-installer-don-8221.0
docker cp installer:/app/installer ./installer
docker rm -f installer
./installer init > gitpod.config.yaml
./installer render --config gitpod.config.yaml > gitpod.yaml

Verify that workspace-templates configmap has no templates like this:

apiVersion: v1
kind: ConfigMap
metadata:
  creationTimestamp: null
  labels:
    app: gitpod
    component: ws-manager
    gitpod.io/nodeService: ws-manager
  name: workspace-templates
  namespace: default

Release Notes

[installer] Installer does not set default nameserver settings for workspaces anymore

@corneliusludmann corneliusludmann requested a review from a team February 17, 2022 19:54
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Feb 17, 2022
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #8288 (b58fee9) into main (6497329) will decrease coverage by 23.63%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #8288       +/-   ##
==========================================
- Coverage   31.23%   7.60%   -23.64%     
==========================================
  Files          39      31        -8     
  Lines        5910    2171     -3739     
==========================================
- Hits         1846     165     -1681     
+ Misses       3923    2003     -1920     
+ Partials      141       3      -138     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-installer-raw-app 4.58% <ø> (?)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-supervisor-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/installer/pkg/components/ws-manager/configmap.go 24.37% <ø> (ø)
components/local-app/pkg/auth/auth.go
components/supervisor/pkg/terminal/ring-buffer.go
components/supervisor/pkg/supervisor/tasks.go
components/supervisor/pkg/supervisor/services.go
components/supervisor/pkg/ports/tunnel.go
components/supervisor/pkg/config/gitpod-config.go
components/supervisor/pkg/ports/served-ports.go
components/supervisor/pkg/supervisor/config.go
components/supervisor/pkg/terminal/terminal.go
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6497329...b58fee9. Read the comment docs.

@roboquat roboquat merged commit 6f8bbba into main Feb 18, 2022
@roboquat roboquat deleted the clu/installer-don-8221 branch February 18, 2022 09:51
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/M team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[installer] Don't set default workspace template when no workspace template is given
3 participants