[ws-manager-bridge] fix error handling for register & update, show all admission-constraints for list

[kylos101]

Description

The following changes are necessary to improve the experience for managing workspace clusters when using gpctl.

1. Cluster list was not showing certain admission constraints, like has-more-resources. As an administrator, we want to see all admission constraints, so we can understand how access is controlled to workspace clusters.
2. It was possible to register duplicate workspace cluster names. As an administrator, we want to prevent overwriting existing configured clusters and prevent unwanted behavior, so we can maximize system up-time and have predictability.
3. The error message for update when a workspace cluster name does not exist was incorrect. As an administrator, we want to clearly see what is wrong when updating, so we can effectively manage configuration.

Related Issue(s)

These issues were found while building and and testing faster clusters for #8054.

How to test

The error message when a name does not exist on update:

gitpod /workspace/gitpod (kyleb/faster-clusters) $ gpctl clusters update score 0 --name defaul2
FATA[0001] rpc error: code = Unknown desc = a WorkspaceCluster with name defaul2 does not exist in the DB! 

update still works:

gitpod /workspace/gitpod (kyleb/faster-clusters) $ gpctl clusters update admission-constraint add has-more-resources --name workworkwork
cluster 'workworkwork' updated with admission constraint add:true  constraint:{has_more_resources:true}
gitpod /workspace/gitpod (kyleb/faster-clusters) $ gpctl clusters list
NAME                URL                           STATIC        STATE            SCORE        GOVERNED        ADMISSION CONSTRAINTS
workworkwork        5.6.7.8:9090           false         AVAILABLE        50           true            [has_more_resources:true]
default             dns:///ws-manager:8080        true          AVAILABLE        50           true            []

The output for list when a workspace cluster includes has-more-resources admission constraint:

#
gitpod /workspace/gitpod (kyleb/faster-clusters) $ gpctl clusters list
NAME                URL                           STATIC        STATE            SCORE        GOVERNED        ADMISSION CONSTRAINTS
workworkwork        5.6.7.8:9090           false         AVAILABLE        10000        true            [has_more_resources:true]
default             dns:///ws-manager:8080        true          AVAILABLE        50           true            []

The error when you try to register a workspace cluster with a name that already exists:

gitpod /workspace/gitpod (kyleb/faster-clusters) $ gpctl clusters list
NAME                URL                           STATIC        STATE            SCORE        GOVERNED        ADMISSION CONSTRAINTS
workworkwork        5.6.7.8:9090           false         CORDONED         50           true            []
default             dns:///ws-manager:8080        true          AVAILABLE        50           true            []
gitpod /workspace/gitpod (kyleb/faster-clusters) $ gpctl clusters register --name workworkwork --hint-cordoned --hint-govern --url 5.6.7.8:9090 --tls-path ./wsman-tls/
FATA[0001] rpc error: code = Unknown desc = a WorkspaceCluster with name workworkwork already exists in the DB 

Register still works:

gitpod /workspace/gitpod (kyleb/faster-clusters) $ gpctl clusters list
NAME           URL                           STATIC        STATE            SCORE        GOVERNED        ADMISSION CONSTRAINTS
default        dns:///ws-manager:8080        true          AVAILABLE        50           true            []
gitpod /workspace/gitpod (kyleb/faster-clusters) $ gpctl clusters register --name workworkwork --hint-cordoned --hint-govern --url 5.6.7.8:9090 --tls-path ./wsman-tls/
cluster registered: name:"workworkwork"  url:"5.6.7.8:9090"  tls:{redacted}  hints:{cordoned:true  govern:true}

Release Notes

Improve error handling for workspace cluster register & update
Show all admission constraints for workspace cluster list

Documentation

[codecov]

Codecov Report

Merging #8330 (5031e01) into main (6497329) will decrease coverage by 20.05%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #8330       +/-   ##
===========================================
- Coverage   31.23%   11.17%   -20.06%     
===========================================
  Files          39       18       -21     
  Lines        5910      993     -4917     
===========================================
- Hits         1846      111     -1735     
+ Misses       3923      880     -3043     
+ Partials      141        2      -139     

Flag	Coverage Δ
components-gitpod-cli-app	11.17% <ø> (ø)
components-local-app-app-darwin-amd64	?
components-local-app-app-darwin-arm64	?
components-local-app-app-linux-amd64	?
components-local-app-app-linux-arm64	?
components-local-app-app-windows-386	?
components-local-app-app-windows-amd64	?
components-local-app-app-windows-arm64	?
components-supervisor-app	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...mponents/supervisor/pkg/supervisor/notification.go
components/supervisor/pkg/supervisor/services.go
components/supervisor/pkg/supervisor/supervisor.go
components/supervisor/pkg/supervisor/user.go
components/supervisor/pkg/dropwriter/dropwriter.go
components/supervisor/pkg/ports/exposed-ports.go
components/local-app/pkg/auth/auth.go
components/supervisor/pkg/ports/tunnel.go
components/supervisor/pkg/supervisor/tasks.go
components/supervisor/pkg/supervisor/config.go
... and 11 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6497329...5031e01. Read the comment docs.

[sagor999]

hm. what if findFiltered will change in the future and will return something other than array?

[kylos101]

Good point, since it's TypeScript this is overkill, null check and length check should be good. Thanks!

[geropl]

Thx for finding and fixing this @kylos101 🙏