[server] make ping pong async #8348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roboquat
added
size/S
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
Codecov Report
@@ Coverage Diff @@
## main #8348 +/- ##
===========================================
- Coverage 28.28% 11.17% -17.11%
===========================================
Files 41 18 -23
Lines 3490 993 -2497
===========================================
- Hits 987 111 -876
+ Misses 2447 880 -1567
+ Partials 56 2 -54
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
geropl
reviewed
Feb 21, 2022
| setPingSent(ws, Date.now()); | ||
| ws.ping(); // if this fails it triggers a ws error, and fails the ws anyway | ||
|
|
||
| // note: decoupling by using `setImmediate` in order to offload to the following event loop iteration. |
geropl
reviewed
Feb 21, 2022
| @@ -93,7 +101,14 @@ export class WsConnectionHandler implements Disposable { | |||
| }); | |||
| ws.on('ping', (data: any) => { | |||
| // answer browser-side ping to conform RFC6455 (https://tools.ietf.org/html/rfc6455#section-5.5.2) | |||
| ws.pong(data); | |||
| // note: decoupling by using `setImmediate` in order to offload to the following event loop iteration. | |||
geropl
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's make ping pong less sync.