[Analytics] Prepare for Mixpanel Migration of website Insights #8354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/werft run 👍 started the job as gitpod-build-mixpanel-migration-prep.1 |
Codecov Report
@@ Coverage Diff @@
## main #8354 +/- ##
=========================================
+ Coverage 8.42% 11.17% +2.75%
=========================================
Files 33 18 -15
Lines 2339 993 -1346
=========================================
- Hits 197 111 -86
+ Misses 2137 880 -1257
+ Partials 5 2 -3
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
roboquat
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
|
/werft run 👍 started the job as gitpod-build-mixpanel-migration-prep.2 |
|
Starting review now... |
geropl
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR prepares to move visitor (i.e. everyone but authenticated user) data out of mixpanel through the following two steps:
SegmentAnalyticsWriterto feature the integrations object in the payload, which ensures that an event is not forwarded to Mixpanel if the user is not authenticated. This has to be specified in the app as the event filtering in Segment unfortunately does not allow to check for the existence ofuserIdThese two changes are prerequisites to converting to a paying subscription with Mixpanel as we would else either risk data loss or a spike in the cost of ownership.
Related Issue(s)
How to test
page()call whetherintegrationsexists with"Mixpanel": false(the initial page call should occur before authenticating and thus not be forwarded to Mixpanel as theuserIdis not passed along)signuptrack event sent to Segment thatintegrationsexists with"Mixpanel": true(signups always contain theuserId, so Segment should forward this to Mixpanel). Then, check that the signup event contains aqualifiedproperty with the valuefalse(as the cookiegitpod-marketing-website-visitedshould not yet exist for this domain)gitpod-marketing-website-visited=true(current domain, expiry at least session; one way to do this is to go to the console of the developer tool and enterdocument.cookie="gitpod-marketing-website-visited=true")signupevent call and make sure that thequalifiedproperty in the Segment Debugger istruethis timeRelease Notes
Documentation
/werft analytics=segment|TEZnsG4QbLSxLfHfNieLYGF4cDwyFWoe