Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jb]: customize remote indicator #8371

Merged
merged 1 commit into from
Feb 22, 2022
Merged

[jb]: customize remote indicator #8371

merged 1 commit into from
Feb 22, 2022

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Feb 22, 2022

Description

This PR customizes the remote indicator in the thin client to show Gitpod logo and workspace ID.
Screenshot 2022-02-22 at 06 22 19

Related Issue(s)

Fixes #8192

How to test

Release Notes

NONE

Documentation

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #8371 (95fc3d7) into main (7ccac75) will decrease coverage by 1.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8371      +/-   ##
==========================================
- Coverage   12.31%   11.17%   -1.14%     
==========================================
  Files          20       18       -2     
  Lines        1161      993     -168     
==========================================
- Hits          143      111      -32     
+ Misses       1014      880     -134     
+ Partials        4        2       -2     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ccac75...95fc3d7. Read the comment docs.

@akosyakov akosyakov marked this pull request as ready for review February 22, 2022 05:46
@akosyakov akosyakov requested a review from a team February 22, 2022 05:46
Copy link
Contributor

@felladrin felladrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reviewed and IDE tested ✅

Before:

image

After:

image

@roboquat roboquat merged commit f8257e4 into main Feb 22, 2022
@roboquat roboquat deleted the ak/jb_remote_indicator branch February 22, 2022 08:19
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/L team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[jetbrains] extend IDE backend label
3 participants