Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update helm cpu limit #8393

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Update helm cpu limit #8393

merged 1 commit into from
Feb 22, 2022

Conversation

Furisto
Copy link
Member

@Furisto Furisto commented Feb 22, 2022

Description

Updates the helm cpu limit, similar to https://github.com/gitpod-io/ops/pull/1280. Still required as some teams still use the helm installer.

Related Issue(s)

n.a.

How to test

  • Open workspace
  • Check resource limits of workspace pod

Release Notes

NONE

@Furisto
Copy link
Member Author

Furisto commented Feb 22, 2022

/werft run with-helm

👍 started the job as gitpod-build-fo-up-helm-cpu.1

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #8393 (b14f25e) into main (d9b9f30) will increase coverage by 2.75%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            main    #8393      +/-   ##
=========================================
+ Coverage   8.41%   11.17%   +2.75%     
=========================================
  Files         33       18      -15     
  Lines       2340      993    -1347     
=========================================
- Hits         197      111      -86     
+ Misses      2138      880    -1258     
+ Partials       5        2       -3     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
install-installer-raw-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
.../installer/pkg/components/ws-manager/deployment.go
...staller/pkg/components/ws-manager/networkpolicy.go
install/installer/pkg/common/display.go
...l/installer/pkg/components/ws-manager/configmap.go
install/installer/pkg/common/storage.go
install/installer/pkg/common/objects.go
...components/ws-manager/unpriviledged-rolebinding.go
...nstall/installer/pkg/components/ws-manager/role.go
...installer/pkg/components/ws-manager/rolebinding.go
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9b9f30...b14f25e. Read the comment docs.

@Furisto
Copy link
Member Author

Furisto commented Feb 22, 2022

/werft run with-helm with-clean-slate-deployment

👍 started the job as gitpod-build-fo-up-helm-cpu.2

@Furisto Furisto marked this pull request as ready for review February 22, 2022 16:12
@Furisto Furisto requested a review from a team February 22, 2022 16:17
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Feb 22, 2022
@roboquat roboquat merged commit 2dce413 into main Feb 22, 2022
@roboquat roboquat deleted the fo/up-helm-cpu branch February 22, 2022 18:17
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants